From owner-svn-src-all@FreeBSD.ORG Sun Nov 17 18:16:26 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 72C9D687; Sun, 17 Nov 2013 18:16:26 +0000 (UTC) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) by mx1.freebsd.org (Postfix) with ESMTP id B6DCC2B8D; Sun, 17 Nov 2013 18:16:25 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MWF00K00604KF00@smtpauth3.wiscmail.wisc.edu>; Sun, 17 Nov 2013 12:16:09 -0600 (CST) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.11.17.180315, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from comporellon.tachypleus.net (adsl-76-208-69-44.dsl.mdsnwi.sbcglobal.net [76.208.69.44]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MWF008LG6QOOP10@smtpauth3.wiscmail.wisc.edu>; Sun, 17 Nov 2013 12:16:06 -0600 (CST) Message-id: <528907DF.8040904@freebsd.org> Date: Sun, 17 Nov 2013 12:15:59 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 To: Eitan Adler Subject: Re: svn commit: r258250 - head/sys/powerpc/fpu References: <201311170503.rAH53F27033585@svn.freebsd.org> In-reply-to: Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 18:16:26 -0000 On 11/17/13 12:14, Eitan Adler wrote: > On Sun, Nov 17, 2013 at 12:03 AM, Nathan Whitehorn > wrote: >> Modified: head/sys/powerpc/fpu/fpu_explode.c >> ============================================================================== >> --- head/sys/powerpc/fpu/fpu_explode.c Sun Nov 17 03:11:36 2013 (r258249) >> +++ head/sys/powerpc/fpu/fpu_explode.c Sun Nov 17 05:03:15 2013 (r258250) >> @@ -235,6 +235,7 @@ fpu_explode(struct fpemu *fe, struct fpn >> s = fpu_dtof(fp, s, space[1]); >> break; >> >> + default: >> panic("fpu_explode"); >> panic("fpu_explode: invalid type %d", type); >> } > Why are there two panic calls here? > > That's a fascinating question. This code was ... interesting. I'll get rid of the first useless one. Thanks! -Nathan