From owner-freebsd-multimedia Sun Jul 13 13:34:45 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id NAA06267 for multimedia-outgoing; Sun, 13 Jul 1997 13:34:45 -0700 (PDT) Received: from whqvax.picker.com (whqvax.picker.com [144.54.1.1]) by hub.freebsd.org (8.8.5/8.8.5) with SMTP id NAA06262 for ; Sun, 13 Jul 1997 13:34:42 -0700 (PDT) Received: from ct.picker.com by whqvax.picker.com with SMTP; Sun, 13 Jul 1997 16:34:11 -0400 (EDT) Received: from elmer.ct.picker.com ([144.54.57.34]) by ct.picker.com (4.1/SMI-4.1) id AA26109; Sun, 13 Jul 97 16:34:10 EDT Received: by elmer.ct.picker.com (SMI-8.6/SMI-SVR4) id QAA05293; Sun, 13 Jul 1997 16:32:10 -0400 Message-Id: <19970713163210.43120@ct.picker.com> Date: Sun, 13 Jul 1997 16:32:10 -0400 From: Randall Hopper To: Amancio Hasty Cc: multimedia@freebsd.org Subject: Re: guspnp9 feedback References: <19970713155256.41366@ct.picker.com> <199707132010.NAA07974@rah.star-gate.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.76 In-Reply-To: <199707132010.NAA07974@rah.star-gate.com>; from Amancio Hasty on Sun, Jul 13, 1997 at 01:10:20PM -0700 Sender: owner-multimedia@freebsd.org X-Loop: FreeBSD.org Precedence: bulk As I said, it's not just the return type. < long attach_awe_obsolete(long mem_start, struct address_info *hw_config); > void attach_awe_obsolete(struct address_info *hw_config); Randall Amancio Hasty: |In /sys/i386/isa/sound/sound_calls.h change the prototype from void to int: | |/* From awe_wave.c */ |int attach_awe_obsolete(struct address_info *hw_config); | |Recompile the kernel and please let us know if the driver works for you. | | Tnks, | Amancio | | |From The Desk Of Randall Hopper : |> Had a few minutes to sit down and build the latest driver. It appears |> that you changed some protos in sound_calls.h and didn't flow them to all |> the .c files. attach looks like it now returns void rather than long and |> doesn't take a mem_start arg anymore. |> |> Not knowing what the intent was, I'm not sure I'd make the right fix. |> Can you update the code and mail me the diffs. Also, you might build a |> sound driver with all the devices compiled in. That should be a pretty |> good build stress-test for the upcoming release. (In particular, adding: |> |> device awe0 at isa? port 0x620 |> |> will show the below problem.)