Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Jul 1997 16:32:10 -0400
From:      Randall Hopper <rhh@ct.picker.com>
To:        Amancio Hasty <hasty@rah.star-gate.com>
Cc:        multimedia@freebsd.org
Subject:   Re: guspnp9 feedback
Message-ID:  <19970713163210.43120@ct.picker.com>
In-Reply-To: <199707132010.NAA07974@rah.star-gate.com>; from Amancio Hasty on Sun, Jul 13, 1997 at 01:10:20PM -0700
References:  <19970713155256.41366@ct.picker.com> <199707132010.NAA07974@rah.star-gate.com>

next in thread | previous in thread | raw e-mail | index | archive | help
As I said, it's not just the return type.

< long attach_awe_obsolete(long mem_start, struct address_info *hw_config);
> void attach_awe_obsolete(struct address_info *hw_config);

Randall

Amancio Hasty:
 |In /sys/i386/isa/sound/sound_calls.h change the prototype from void to int:
 |
 |/*  From awe_wave.c  */
 |int  attach_awe_obsolete(struct address_info *hw_config);
 |
 |Recompile the kernel and please let us know if the driver works for you.
 |
 |	Tnks,
 |	Amancio
 |
 |
 |From The Desk Of Randall Hopper :
 |>      Had a few minutes to sit down and build the latest driver.  It appears
 |> that you changed some protos in sound_calls.h and didn't flow them to all
 |> the .c files.  attach looks like it now returns void rather than long and
 |> doesn't take a mem_start arg anymore.  
 |> 
 |>      Not knowing what the intent was, I'm not sure I'd make the right fix.
 |> Can you update the code and mail me the diffs.  Also, you might build a
 |> sound driver with all the devices compiled in.  That should be a pretty
 |> good build stress-test for the upcoming release.  (In particular, adding:
 |> 
 |> device awe0     at isa? port 0x620
 |> 
 |> will show the below problem.)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970713163210.43120>