From owner-cvs-all@FreeBSD.ORG Mon Feb 28 18:26:20 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B497C16A4CE; Mon, 28 Feb 2005 18:26:20 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B37B43D4C; Mon, 28 Feb 2005 18:26:20 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id j1SIQIvA057169; Mon, 28 Feb 2005 10:26:18 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id j1SIQIFX057168; Mon, 28 Feb 2005 10:26:18 -0800 (PST) (envelope-from obrien) Date: Mon, 28 Feb 2005 10:26:18 -0800 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20050228182618.GB56766@dragon.nuxi.com> References: <200502280923.j1S9NcKE004088@repoman.freebsd.org> <20050228093414.GA74879@ip.net.ua> <20050228093622.GB74879@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050228093622.GB74879@ip.net.ua> X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.8i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 src/share/mk bsd.compat.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2005 18:26:20 -0000 On Mon, Feb 28, 2005 at 11:36:22AM +0200, Ruslan Ermilov wrote: > On Mon, Feb 28, 2005 at 11:34:14AM +0200, Ruslan Ermilov wrote: > > On Mon, Feb 28, 2005 at 09:23:38AM +0000, David E. O'Brien wrote: > > > obrien 2005-02-28 09:23:38 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > . Makefile.inc1 > > > share/mk bsd.compat.mk > > > Log: > > > Accept the old user interface for NO_CLEAN as it is a POLA violation as > > > we've eventually changed the user interface of a common command. > > > > > > Revision Changes Path > > > 1.486 +3 -0 src/Makefile.inc1 > > > 1.19 +0 -1 src/share/mk/bsd.compat.mk > > > > > Why did you do this? bsd.compat.mk already handled this, and > > Makefile.inc1 is always called with ``-m /usr/src/share/mk''. > > Even if you call Makefile.inc1 directly, and your /usr/share/mk > > is up-to-date, you'll get a warning and setting. Would you > > please revert this change? > > > Or maybe I misunderstood you, and you just wanted it to be quiet? > Even so, please handle it all in bsd.compat.mk. Looking at bsd.compat.mk, especially with "BURN_BRIDGES" in there; I'd like to ask you for a patch you'd be happy with that isn't going away in a few months when the bridges burn. A correct patch will have to add another layer of .if statements in the case of "NOCLEAN". -- -- David (obrien@FreeBSD.org)