From owner-svn-src-head@freebsd.org Fri Feb 17 15:52:10 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7354CE33CE; Fri, 17 Feb 2017 15:52:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 583BF1A4B; Fri, 17 Feb 2017 15:52:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr0-x230.google.com with SMTP id i10so32264827wrb.0; Fri, 17 Feb 2017 07:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6BhJUl/v8ZzH9CVojlMenNGMLvrx4d85pifyC0P8b7g=; b=BjUFd1jkP9XSHSY5XY6RQlmlfIcCqQwmE3HkN9iyL25YEUFzEcUVk0qU+QFOzmikEy dldgHBSU0XB3UE1JIkw2Bt+OjqmMwN50CxaleY4r/KfgE/SRYQt6PgMy5Zmf0WWvjCqf yeIg8wrAF7DA+7Vy8tE/abWIXWFsConKJ2UdV6fH5Y9ozNyudURud8AMFW/RCLTs3MoR O/BcTjo+SeGQr/2rjh9TWf0EA6E2xL6rwJ8GFWLBkCpVR3X+hGmJ9kSsBtLC1cdAH+Up Z6MAjzc9pjBURO8izo0yEV12B/DGvMYaKZzMPo2BdJxKYwfy2FAZMLvVo5Bao9UB5jiw Zdqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6BhJUl/v8ZzH9CVojlMenNGMLvrx4d85pifyC0P8b7g=; b=ugfuieDZMwNnq9G9hx6eKtq7txYeifn6R8GMEIme82TCLped7D7aproUyda1uDReWl sA/3o9DInAO/sWst1+uz8fdTxB0I9xfexTYygOYQ/rJ5RUtpmNjlLyulLq0WVjO4nfhd //5+peRrAa4FcTN99R0/dPgbG5Lg0+CsfuZnU2Bd72EVi+NcP9kIYyOVM7aLkSb4yiu3 4AC6ZMumhE/dX4Ta75n1dwmsosjDok2+6vrizXsLG+rLIjWjNk8egb7sbuFlJ3JziTyq ot4R4PZn94+EBpSkXMK5I9wQwzR+Qr3dTgVXt+J29AIJ52F0xZrf90iRp3yBibB2jIc6 ZdqQ== X-Gm-Message-State: AMke39lfoZb7nMn+QvgGHdF4cNxKivwWTuhrNoXMSodF2MsbmjkrQWnlMt5SV/l5NHxZlA== X-Received: by 10.223.150.59 with SMTP id b56mr7286905wra.192.1487346728628; Fri, 17 Feb 2017 07:52:08 -0800 (PST) Received: from brick (global-5-142.nat-2.net.cam.ac.uk. [131.111.5.142]) by smtp.gmail.com with ESMTPSA id c202sm2149079wmd.10.2017.02.17.07.52.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2017 07:52:08 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Fri, 17 Feb 2017 15:52:06 +0000 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313854 - head/sys/cam/ctl Message-ID: <20170217155206.GA40422@brick> Mail-Followup-To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702170522.v1H5MwGK027647@repo.freebsd.org> <20170217102408.GA74901@brick> <653994e0-b49f-21ac-3bdc-d6fc34496b29@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <653994e0-b49f-21ac-3bdc-d6fc34496b29@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 15:52:10 -0000 On 0217T1522, Alexander Motin wrote: > On 17.02.2017 12:24, Edward Tomasz Napierała wrote: > > On 0217T0522, Alexander Motin wrote: > >> Author: mav > >> Date: Fri Feb 17 05:22:58 2017 > >> New Revision: 313854 > >> URL: https://svnweb.freebsd.org/changeset/base/313854 > >> > >> Log: > >> Change the way MaxCmdSN is used. > >> > >> Before this change MaxCmdSN was reported as CmdSN + delta, that made it > >> limit number of requests in transmission from the initiator to target, > >> that was pretty useless. After this change MaxCmdSN limits number of > >> requests queued to CTL, i.e. maximal queue depth for the initiator. > >> The default limit is 256 outstanding requests per initiator at a time. > >> > >> This code uses existing cs_outstanding_ctl_pdus counter to track queue > >> depth. It's semantics doen't perfectly match, but close enough to not > >> add another counter. Just don't set the maxtags below 2. > > > > I like the change in principle, but I don't like the gratuitous change > > of sysctl name. It will break people's configs. Could you rename it > > back? Thanks! > > But its meaning is different now. Do you know anybody tuning the old > sysctl? I can't imagine who would do it and what for. Yes. It's been asked about a few times on forums, and it's documented in ctl(4). The new meaning is slightly different, sure, but I'd say it's very close, except that now it really works :-)