Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Jun 2012 22:32:15 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r237133 - head/sys/kern
Message-ID:  <20120615222251.T1609@besplex.bde.org>
In-Reply-To: <201206151000.q5FA0TQM061466@svn.freebsd.org>
References:  <201206151000.q5FA0TQM061466@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 15 Jun 2012, Pawel Jakub Dawidek wrote:

> Log:
>  One more attempt to make prototypes formated according to style(9),

Thanks.  The prototypes look OK now.

>  which
>  holefully recovers from the "worse than useless" state.

Er, my "worse than useless" description wasn't about prototypes.  It
was about putting a tab in the middle of type a declaration.  The tab
lines up some identifier, but this is worse than useless since it
makes things look like they are lined up, but when you look closer
you see that the wrong things are lined up.  Example:

struct fstat_args {
 	int	fd;
 	struct	stat *sb;
};

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120615222251.T1609>