Date: Wed, 9 Sep 2009 11:39:39 +0200 From: Attilio Rao <attilio@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: arch@freebsd.org, freebsd-arch@freebsd.org Subject: Re: NEWBUS states (was Re: svn commit: r196779 - in head/sys: kern sys) Message-ID: <3bbf2fe10909090239r519ae737t56ddd7ca36e5f84d@mail.gmail.com> In-Reply-To: <200909080936.37603.jhb@freebsd.org> References: <200909031340.n83Defkv034013@svn.freebsd.org> <20090904.161634.-217944108.imp@bsdimp.com> <3bbf2fe10909041546y2b5633e1ue063955568df1a06@mail.gmail.com> <200909080936.37603.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/9/8 John Baldwin <jhb@freebsd.org>: > On Friday 04 September 2009 6:46:03 pm Attilio Rao wrote: >> We all agreed the one-state was the better option but it can't be done >> in this way because of the device_is_attached() used in the detach >> virtual functions. Using just one transition state will break >> device_is_attached() in those parts. >> The right fix, as pointed out in other e-mails, is to not use >> device_is_attached() in detach virtual functions. The better fix, in >> my idea would involve: >> - replace the device_is_attached() usage in detach virtual functions, >> with a more functional support >> - use one-state transition >> >> But that is just too much job to push in before then 8.0-REL and if >> that would mean to not commit a patch and make impossible a future >> MFC, I prefer to go with a lesser-perfect-but-still-working-approach. > > Wait, all you need to MFC is the change to the enum. Fixing the various > detach routines does _not_ have to be in 8.0. That could be merged after the > release. That's not what I mean. What I mean is that in order to have a perfect job right now (and have single-state transition usable *right now* by both STABLE_8 and HEAD) that what should happen, which is impractical. I was just explaining to Warner why we didn't go with the single-state in the end. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10909090239r519ae737t56ddd7ca36e5f84d>