Date: Thu, 31 May 2018 07:04:01 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228608] [NEW PORT] net/zmqpp: 0mq highlevel C++ bindings Message-ID: <bug-228608-7788-WV0ch7aIEa@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-228608-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-228608-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228608 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-qa CC| |tobik@freebsd.org --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- XMASTER_SITES=3D https://github.com/zeromq/zmqpp/archive/ XDISTNAME=3D ${PORTVERSION} [...] XWRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION} This is bogus. Please use USE_GITHUB and GH_ACCOUNT. Then you don't need to set WRKSRC and will automatically have a unique distfile name. Some other problems: - Are you sure pathfix is needed? - Why is patch-CMakeLists.txt needed? Use CMAKE_OFF to turn off ZMQPP_BUILD_STATIC. - It's building a shared library, so I highly doubt that NO_ARCH=3Dyes is correct. - The pkg-descr is too short. Maybe include a general description of what zmq is or how zmqpp is different from cppzmq. - Indentation in post-*: is off. Only indent them with one tab. - Either set PORTDOCS or include README.md in the plist but do not use both. - Please provide some confirmation that this builds with Poudriere testport and passes portlint -AC. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228608-7788-WV0ch7aIEa>