From owner-cvs-all Tue Jan 21 15:47:22 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C536137B401; Tue, 21 Jan 2003 15:47:20 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09D8D43ED8; Tue, 21 Jan 2003 15:47:18 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id KAA11659; Wed, 22 Jan 2003 10:18:25 +1100 Date: Wed, 22 Jan 2003 10:19:58 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Robert Watson Cc: Alfred Perlstein , , Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi In-Reply-To: Message-ID: <20030122100003.K30758-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 21 Jan 2003, Robert Watson wrote: > On Tue, 21 Jan 2003, Alfred Perlstein wrote: > > > Log: > > Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0. > > Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT. > > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists. I noticed a null discussion. I didn't respond since I stopped worrying about -current after GEOM made it unusable for me, and the proposed changed was so obviously wrong that Someone Else would respond. > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists. > To improve code portability and careful thinking by developers, what I'd > like to see is something more like the following: M_WAITOK, which > explicitly requests sleeping indefinitely, M_NOWAIT, which explicitly > requests no sleeping. Rather than a "default" value, a That's exactly what M_WAITOK was supposed to do. Developers just had to think about it since it wasn't really a flag so it was not easy to check automatically. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message