From owner-freebsd-hackers@FreeBSD.ORG Thu Aug 16 02:55:29 2007 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 907CB16A418 for ; Thu, 16 Aug 2007 02:55:29 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) by mx1.freebsd.org (Postfix) with ESMTP id 6B42213C45E for ; Thu, 16 Aug 2007 02:55:29 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-4.cisco.com ([171.71.179.196]) by sj-iport-6.cisco.com with ESMTP; 15 Aug 2007 19:27:02 -0700 X-IronPort-AV: i="4.19,268,1183359600"; d="scan'208"; a="200835670:sNHT50425785" Received: from sj-core-1.cisco.com (sj-core-1.cisco.com [171.71.177.237]) by sj-dkim-4.cisco.com (8.12.11/8.12.11) with ESMTP id l7G2R2Mq000977; Wed, 15 Aug 2007 19:27:02 -0700 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-1.cisco.com (8.12.10/8.12.6) with ESMTP id l7G2R2F4025179; Thu, 16 Aug 2007 02:27:02 GMT Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 15 Aug 2007 19:27:01 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 15 Aug 2007 19:27:01 -0700 Message-ID: <46C3B5DF.8070804@cisco.com> Date: Wed, 15 Aug 2007 22:26:39 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Max Laier , hackers@freebsd.org References: <200708160151.l7G1pMmo080481@repoman.freebsd.org> <200708160403.40779.max@love2party.net> In-Reply-To: <200708160403.40779.max@love2party.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Aug 2007 02:27:01.0558 (UTC) FILETIME=[ED842D60:01C7DFAC] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=3321; t=1187231222; x=1188095222; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/netinet=20sctp_asconf.c=20s ctp_input.c=20sctp_output.c=0A=20sctp_pcb.c=20sctp_timer.c=20sctp_usrreq.c =20sctputil.c |Sender:=20; bh=TCdeU3kezoZUHoOuETZH/SFbVqMtdu9ETeABN+zAkwA=; b=li1rlO69RbwczWvzmpttra15iCWP84SDSsukkTTSKiLgu2ghgg9Bdf7a9PpKnhCf1OiRnBgC 258sFjvjaFV9vDjxhMAJQJmJbYVOrZYz3a5mXMrk4tZezVTloVgK4APm; Authentication-Results: sj-dkim-4; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim4002 verified; ); X-Mailman-Approved-At: Thu, 16 Aug 2007 03:13:47 +0000 Cc: Subject: Re: cvs commit: src/sys/netinet sctp_asconf.c sctp_input.c sctp_output.c sctp_pcb.c sctp_timer.c sctp_usrreq.c sctputil.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2007 02:55:29 -0000 Max Laier wrote: > On Thursday 16 August 2007, you wrote: > >>rrs 2007-08-16 01:51:22 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet sctp_asconf.c sctp_input.c sctp_output.c >> sctp_pcb.c sctp_timer.c sctp_usrreq.c >> sctputil.c >> Log: >> - Remove extra comment for 7.0 (no GIANT here). >> - Remove unneeded WLOCK/UNLOCK of inp for getting TCB lock. >> - Fix panic that may occur when freeing an assoc that has partial >> delivery in progress (may dereference null socket pointer when >> queuing partial delivery aborted notification) >> - Some spacing and comment fixes. >> - Fix address add handling to clear cached routes and source >>addresses when peer acks the add in case the routing table changes. >> Approved by: re@freebsd.org (Bruce Mah) >> >> Revision Changes Path >> 1.24 +49 -2 src/sys/netinet/sctp_asconf.c >> 1.56 +3 -7 src/sys/netinet/sctp_input.c >> 1.49 +48 -41 src/sys/netinet/sctp_output.c >> 1.52 +1 -4 src/sys/netinet/sctp_pcb.c >> 1.26 +0 -2 src/sys/netinet/sctp_timer.c >> 1.42 +1 -2 src/sys/netinet/sctp_usrreq.c >> 1.55 +4 -5 src/sys/netinet/sctputil.c > > > This doesn't include the memset reversion fix on -hackers recently. Just > makeing sure it's not forgotten as I happen to remember just now. No.. this patch was one I submitted 8/7... I did not have the memset patch then.. The patch you speak of is already incorporated into the main CVS tree we (the sctp team) use to support the three O/S's we work on (FreeBSD/MAC-OSX/IOS-XR).... The next patch that is building, patch 15, currently looks as follows: ***************************************************** bash-stewlap: cat list_of_updates - Fix address add handling to clear cached routes and source addresses when peer acks the add in case the routing table changes. - Fix sctp_lower_sosend to send shutdown chunk for mbuf send case when sndlen = 0 and sinfoflag = SCTP_EOF - Fix sctp_lower_sosend for SCTP_ABORT mbuf send case with null data, So that it does not send the "null" data mbuf out and cause it to get freed twice. - Fix so auto-asconf sysctl actually effect the socket's asconf state. - Do not allow SCTP_AUTO_ASCONF option to be used on subset bound sockets. - Memset bug in sctp_output.c (arguments were reversed) submitted found and reported by Dave Jones (davej@codemonkey.org.uk). - PD-API point needs to be invoked >= not just > to conform to socket api draft this fixes sctp_indata.c in the two places need to be >=. ************************************** As you can see Dave's patch is there.. but I have not submitted this yet. The next SCTP-Interop starts Sunday (I am in Japan helping setup for this now) and I think it is best I wait to see what other bugs surface at the interop before queuing the next patch to re... Unless you want me to speed the sending of this up.. if so I can start my make universe builds and begin patch prep.. but if not.. I will wait .. let me know if you want me to do so.. :-D R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)