From owner-svn-src-all@freebsd.org Wed Jul 8 15:42:04 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58352996225 for ; Wed, 8 Jul 2015 15:42:04 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F12101E35 for ; Wed, 8 Jul 2015 15:42:03 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by wibdq8 with SMTP id dq8so216761420wib.1 for ; Wed, 08 Jul 2015 08:42:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=csYl4zT2FiXMsQcRpu8cOqjUuWDAVg5vwnZMACAfyKw=; b=B4h+xtrMnzQrMOPfelOBmObPz86IlHhvx11G/6kADSn0yAe/MK1NnqMCD0AyZYWZiX pVRfJCZ9m5qG2VDRgydDHPmM1DavVrXQosUpdY6SCWSkVvpew4Op5/qiaWxZfZXxKaF7 9H5dSwji+QoXVMwj/B4+TSJxkfDDwp+rhL6ZwMk5wjbqEW4dm3yssO4ugLKRQmHRRDTb q5u0yFAUEL6MJgjzkIfPhrbAnywkOWsddPNgBqP5+TrmOa9kVA6M5jt/egT3oH3YjJII 6I1mWaduKDVc4mgP0JPh9xFRMM9qh2xwjVRq/P4qTqdTRPwBao9AuXkTD0g3Kt0UtwNf 9zjg== X-Gm-Message-State: ALoCoQnHcIv+/H1RovkH7P14dUAGo3YXxPiM4Cf0T6viOYDeyCAXLif/lIcrI9SSc3esN+aoPX3u X-Received: by 10.194.59.98 with SMTP id y2mr21274756wjq.42.1436370121848; Wed, 08 Jul 2015 08:42:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.75.12 with HTTP; Wed, 8 Jul 2015 08:41:42 -0700 (PDT) In-Reply-To: <201507081533.t68FX0Yb077433@repo.freebsd.org> References: <201507081533.t68FX0Yb077433@repo.freebsd.org> From: Zbigniew Bodek Date: Wed, 8 Jul 2015 17:41:42 +0200 Message-ID: Subject: Re: svn commit: r285272 - head/sys/arm64/arm64 To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 15:42:04 -0000 2015-07-08 17:33 GMT+02:00 Andrew Turner : > Author: andrew > Date: Wed Jul 8 15:32:59 2015 > New Revision: 285272 > URL: https://svnweb.freebsd.org/changeset/base/285272 > > Log: > Add support for ipi_all_but_self on arm64. > > Obtained from: ABT Systems Ltd > Sponsored by: The freeBSD Foundation > > Modified: > head/sys/arm64/arm64/intr_machdep.c > > Modified: head/sys/arm64/arm64/intr_machdep.c > ============================================================================== > --- head/sys/arm64/arm64/intr_machdep.c Wed Jul 8 14:07:06 2015 (r285271) > +++ head/sys/arm64/arm64/intr_machdep.c Wed Jul 8 15:32:59 2015 (r285272) > @@ -48,6 +48,7 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > > #include > #include > @@ -473,9 +474,16 @@ arm_init_secondary(void) > void > ipi_all_but_self(u_int ipi) > { > + cpuset_t other_cpus; > > - /* ARM64TODO: We should support this */ > - panic("ipi_all_but_self"); > + other_cpus = all_cpus; > + CPU_CLR(PCPU_GET(cpuid), &other_cpus); > + > + /* ARM64TODO: This will be fixed with arm_intrng */ > + ipi += 16; BTW. Can you explain why we need += 16 here? We think this is wrong and we will probably try to upstream patches that i.a. remove this. Best regards zbb > + > + CTR2(KTR_SMP, "%s: ipi: %x", __func__, ipi); > + PIC_IPI_SEND(root_pic, other_cpus, ipi); > } > > void > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"