From nobody Wed Nov 26 20:35:38 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dGrt25CNRz6HPtq for ; Wed, 26 Nov 2025 20:35:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dGrt24Fx3z3S6j for ; Wed, 26 Nov 2025 20:35:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764189338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F5HdoaC6VzmDqSE12pAVjFaQkIkExr9+PzaMjYpOTlU=; b=YRBbiD7T3EmDCNHJZz/RsLYsJVuoOOPH65DCwUWA8JsLuVEaS5KkNViQ7fLLevBc635Ts7 PVHlhwu0iZTU31eIRPAJIezD5nJBm8NIUYzf0hudCewD6wfA4bYj/K3fVFjIdgv7XMenoK nRqMdpf5td5NeAjs5sYI9IL5XN1yEQOwxYGIdxYGr4WQiuEUqPkelg96hgGZe09nK1Dwb+ hxt3rhfLqTSgVtThbYcezM16+guB8SH01p0aC02FlIZLuuDoweh272136eOxOIM0sPOB63 RP/rFvf8LOB+M7Ng3gCIFMYuya/dgNVuu1yol4DrocRFv6fgzRE/7hJJlh6vEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764189338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F5HdoaC6VzmDqSE12pAVjFaQkIkExr9+PzaMjYpOTlU=; b=t4Y654eSkuUvn56ruE4g9mkCHsIi+2cFFuwM5zU1rJxUAxNcVH0gVUWIDls3/zBWcHbBtV 8bqziRZJT5gnLXNBtl38Fpa0saX0Yw/sAVndPzYWQJKzqT5fVHEjABDFnMZvnCYBFXFK3K ZCa5j3Fg15OELI2VQeKnfYEGWLGL5cttcnk5m0VJ9JyxhbzWUR0fbyXORhAdX8qBNY0XH9 oLwQTldbKKOv6PE3cNHpDCk3Is9vDkNjeg7znoiyW7Bl0aTBwzORXWWt7wzPj45XlYH07H G13PZ2UkRTtKZdIXQy6RuJi+t95AXXkGPNWK/WE+HY0WF+crmNOqWCPKF/nwUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764189338; a=rsa-sha256; cv=none; b=q+BIo8DRdGIalTkxwbWKcvjS7PRgOtaGFwYaWpwtzfFLwMi8vF1yt+dj3+j2hOQvsz71Yp DUKD1Zr5UYz6TKb1da6Yi1X9PBb+N+PafGHRXMkRllD8rvAz4tLx1cyHHs12u8dwFb2z8V hL/ESMuAUmsW0dwxzY6+i/BAXpkz/0O5zdRWuC7oq/u3iaSKWy08VbP1aUL2vjX9zn5j57 OBNclTMDk/btdZjeAg5eW8lw2Pn5HLY7ncKlKcLFfpjeLHYTC5AT863Ida+alU8931ZXEC /ouPaUjLH4hjrwXV+RQHu/NNb5cJW3SaJ7FflSSZ2nYV+RWtQQJ9dmjEcvj0LA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dGrt23kKsz1225 for ; Wed, 26 Nov 2025 20:35:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31526 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Nov 2025 20:35:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jose Luis Duran Subject: git: cf85e7034ad5 - main - strfmon: Fix negative sign handling for C locale List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cf85e7034ad5640b18a3b68d6b291b7bf89bfc80 Auto-Submitted: auto-generated Date: Wed, 26 Nov 2025 20:35:38 +0000 Message-Id: <6927649a.31526.2a622852@gitrepo.freebsd.org> The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=cf85e7034ad5640b18a3b68d6b291b7bf89bfc80 commit cf85e7034ad5640b18a3b68d6b291b7bf89bfc80 Author: Jose Luis Duran AuthorDate: 2025-11-26 20:34:56 +0000 Commit: Jose Luis Duran CommitDate: 2025-11-26 20:34:56 +0000 strfmon: Fix negative sign handling for C locale If the locale's positive_sign and negative_sign values would both be returned by localeconv() as empty strings, strfmon() shall behave as if the negative_sign value was the string "-". This occurs with the C locale. The implementation previously assigned "0" to sign_posn (parentheses around the entire string); now it assigns it to "1" (sign before the string) when it is undefined (CHAR_MAX). Austin Group Defect 1199[1] is applied, changing the requirements for the '+' and '(' flags. [1]: https://www.austingroupbugs.net/view.php?id=1199 Reviewed by: kib MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D53913 --- lib/libc/stdlib/strfmon.c | 2 +- lib/libc/tests/stdlib/strfmon_test.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/libc/stdlib/strfmon.c b/lib/libc/stdlib/strfmon.c index b19d9fc43369..611ac45b9c82 100644 --- a/lib/libc/stdlib/strfmon.c +++ b/lib/libc/stdlib/strfmon.c @@ -457,7 +457,7 @@ __setup_vars(int flags, char *cs_precedes, char *sep_by_space, char *sign_posn, if (*sep_by_space == CHAR_MAX) *sep_by_space = 0; if (*sign_posn == CHAR_MAX) - *sign_posn = 0; + *sign_posn = 1; } static int diff --git a/lib/libc/tests/stdlib/strfmon_test.c b/lib/libc/tests/stdlib/strfmon_test.c index 165ddcc2ab56..c6c20bd26985 100644 --- a/lib/libc/tests/stdlib/strfmon_test.c +++ b/lib/libc/tests/stdlib/strfmon_test.c @@ -205,8 +205,8 @@ ATF_TC_BODY(strfmon_plus_or_parenthesis, tc) { "%(i", "C", "[123.45] [(123.45)]" }, { "%(n", "en_US.UTF-8", "[$123.45] [($123.45)]" }, { "%(i", "en_US.UTF-8", "[USD123.45] [(USD123.45)]" }, - { "%n", "C", "[123.45] [(123.45)]" }, /* XXX */ - { "%i", "C", "[123.45] [(123.45)]" }, /* XXX */ + { "%n", "C", "[123.45] [-123.45]" }, + { "%i", "C", "[123.45] [-123.45]" }, { "%n", "en_US.UTF-8", "[$123.45] [-$123.45]" }, { "%i", "en_US.UTF-8", "[USD123.45] [-USD123.45]" }, }; @@ -253,7 +253,7 @@ ATF_TC_BODY(strfmon_l, tc) const char *locale; const char *expected; } tests[] = { - { "C", "[ **1234.57 ] [ **1234.57 ]" }, /* XXX */ + { "C", "[ **1234.57] [ **1234.57]" }, { "de_DE.UTF-8", "[ **1234,57 €] [ **1.234,57 EUR]" }, { "en_GB.UTF-8", "[ £**1234.57] [ GBP**1,234.57]" }, };