From owner-freebsd-net@FreeBSD.ORG Tue Sep 30 10:14:34 2003 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76D0E16A4B3 for ; Tue, 30 Sep 2003 10:14:34 -0700 (PDT) Received: from mail.speakeasy.net (mail9.speakeasy.net [216.254.0.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09A0843FE9 for ; Tue, 30 Sep 2003 10:14:33 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13174 invoked from network); 30 Sep 2003 17:14:32 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 30 Sep 2003 17:14:32 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h8UHES6Y058924; Tue, 30 Sep 2003 13:14:29 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20031001011119.U1245@gamplex.bde.org> Date: Tue, 30 Sep 2003 13:14:34 -0400 (EDT) From: John Baldwin To: Bruce Evans X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: arch@freebsd.org cc: net@freebsd.org Subject: Re: finishing the if.h/if_var.h split X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2003 17:14:34 -0000 On 30-Sep-2003 Bruce Evans wrote: > On Tue, 30 Sep 2003, John Baldwin wrote: > >> On 30-Sep-2003 Bruce Evans wrote: >> > On Mon, 29 Sep 2003, Brooks Davis wrote: >> >> Unfortunately, "soon" hasn't happened yet and it is now tripping me >> >> up. To add the if_dev member to struct ifnet (see the forthcoming >> >> post on that subject), it is necessary for sys/bus.h to be included in >> >> net/if_var.h >> > >> > That would be namespace pollution, so it is not permitted :-). Requiring >> > all files that include (and especially to >> > include would be interface breakage so it is even less >> > permitted. >> >> Well, if if.h stops including if_var.h, then only kernel files that >> include net/if_var.h would need sys/bus.h. I think that's manageable. > > All userland files that include net/if_var.h would also need it (except > they would only need device_t). Is struct ifnet exposed to userland? Ugh, why do we export such things? I guess because ifconfig grovels around in the kernel due to a lack of APIs between the kernel and userland. *sigh* >> >> which in turn requires that if_var.h NOT be included in >> >> genassym.c. >> > >> > Do you mean in userland? There don't seem to be any immediate problems >> > for genassym.c or any other file in the kernel from including >> > unconditionally in . However, the pollution may be harmful >> ... >> The problem is that the newbus foo_if.h files don't exist when genassym >> is compiled and used. sys/bus.h needs bus_if.h and device_if.h, hence >> the breakage. > > I see. This is a bug in the dependencies for genassym.o and .depend. > "make depend" creates *_if.h but it also creates genassym.o. There aren't > enough dependencies so the order is mostly accidental. genassym.o happens > to get created first, so it doesn't compile unless *_if.h already exist. I think that genassym shouldn't need anything that includes *_if.h headers, and that if we find ourselves in that situation, perhaps some huge header needs to be split up instead. :) We shouldn't be going near new-bus or kobj in assembly files. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/