From owner-svn-src-projects@FreeBSD.ORG Thu Dec 23 09:30:30 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2839610656E2; Thu, 23 Dec 2010 09:30:30 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id C60638FC14; Thu, 23 Dec 2010 09:30:28 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 4050A45C89; Thu, 23 Dec 2010 10:10:24 +0100 (CET) Received: from localhost (89-73-192-49.dynamic.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 52E7D45685; Thu, 23 Dec 2010 10:10:19 +0100 (CET) Date: Thu, 23 Dec 2010 10:10:16 +0100 From: Pawel Jakub Dawidek To: Alexander Motin Message-ID: <20101223090812.GA43446@garage.freebsd.pl> References: <201012220902.oBM92MpZ098772@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline In-Reply-To: <201012220902.oBM92MpZ098772@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216649 - projects/graid/head/sys/geom/raid X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2010 09:30:30 -0000 --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote: > Author: mav > Date: Wed Dec 22 09:02:22 2010 > New Revision: 216649 > URL: http://svn.freebsd.org/changeset/base/216649 >=20 > Log: > Implement basic metadata generation check. To be sure that used metadat= a is > up to date - delay volumes creation until we have all disks or timeout > expires. This probably obsolete same functionality done at volumes leve= l. [...] > +static struct intel_raid_conf * > +intel_meta_copy(struct intel_raid_conf *meta) > +{ > + struct intel_raid_conf *nmeta; > + > + nmeta =3D malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO); > + memcpy(nmeta, meta, meta->config_size); > + return (nmeta); > +} The M_ZERO flag seems to be redundant, as you fill the entire buffer in the next line. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk0TEfcACgkQForvXbEpPzRvMQCcCCWhgrakk9OEm3cnQjK9wjuT LosAn3/w4KYxA4fMkJdt8weg22aJKvV8 =rbHv -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE--