Date: Thu, 24 May 2012 18:17:42 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Edward Tomasz Napierala <trasz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235918 - head/sys/geom/label Message-ID: <4FBEB386.7000503@FreeBSD.org> In-Reply-To: <4FBEA14E.2060802@FreeBSD.org> References: <201205241648.q4OGmXha049187@svn.freebsd.org> <4FBEA14E.2060802@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------030401010906040706090801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2012-05-24 16:59:58 -0400, Jung-uk Kim wrote: > On 2012-05-24 12:48:33 -0400, Edward Tomasz Napierala wrote: >> Author: trasz Date: Thu May 24 16:48:33 2012 New Revision: 235918 >> URL: http://svn.freebsd.org/changeset/base/235918 >> >> Log: Make g_label(4) ignore provider size when looking for UFS >> labels. Without it, it fails to create labels for filesystems >> resized by growfs(8). >> >> PR: kern/165962 Submitted by: Olivier Cochard-Labbe <olivier at >> cochard dot me> >> >> Modified: head/sys/geom/label/g_label_ufs.c > > This commit broke my fstab based on ufsid. I have something like > this in my fstab: > > /dev/ufsid/44b3df81873011b5 / ufs rw,noatime 1 1 > /dev/ufsid/463b935456452bbd /tmp ufs rw,noatime 2 2 > /dev/ufsid/44b3dfc4bfcc4c30 /usr ufs rw,noatime 2 2 > /dev/ufsid/463b934b955f63ff /var ufs rw,noatime 2 2 > > Mounting / as read-only went fine and I had /dev/ada0s1a, > /dev/ada0s1d, etc. Strangely, I also had matching ufsid's under > /dev/ufsid, e.g., /dev/ufsid/<some_ufsid>a, > /dev/ufsid/<some_ufsid>d, etc. However, once I do 'mount -u -w /', > everything disappears except for root's ufsid. > > Reverting this commit fixed the problem for me. The attached patch fixed my problem and kern/165962. Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk++s4YACgkQmlay1b9qnVO5uACglaXhj9ZXwpUiroMUxqkbHF/v Qm0An0lHidiRMenHsDLTaiC0Wqz0cYB6 =k1Ff -----END PGP SIGNATURE----- --------------030401010906040706090801 Content-Type: text/plain; charset=UTF-8; name="ufsid.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ufsid.diff" SW5kZXg6IHN5cy9nZW9tL2xhYmVsL2dfbGFiZWxfdWZzLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g c3lzL2dlb20vbGFiZWwvZ19sYWJlbF91ZnMuYwkocmV2aXNpb24gMjM1OTQxKQorKysgc3lz L2dlb20vbGFiZWwvZ19sYWJlbF91ZnMuYwkod29ya2luZyBjb3B5KQpAQCAtNTEsOCArNTEs OSBAQCBzdGF0aWMgdm9pZAogZ19sYWJlbF91ZnNfdGFzdGVfY29tbW9uKHN0cnVjdCBnX2Nv bnN1bWVyICpjcCwgY2hhciAqbGFiZWwsIHNpemVfdCBzaXplLCBpbnQgd2hhdCkKIHsKIAlz dHJ1Y3QgZ19wcm92aWRlciAqcHA7CisJc3RydWN0IGZzICpmczsKKwlvZmZfdCBmc19zaXpl OwogCWludCBzYiwgc3VwZXJibG9jazsKLQlzdHJ1Y3QgZnMgKmZzOwogCiAJZ190b3BvbG9n eV9hc3NlcnRfbm90KCk7CiAJcHAgPSBjcC0+cHJvdmlkZXI7CkBAIC04MiwxMSArODMsMTkg QEAgZ19sYWJlbF91ZnNfdGFzdGVfY29tbW9uKHN0cnVjdCBnX2NvbnN1bWVyICpjcCwgY2gK IAkJaWYgKGZzID09IE5VTEwpCiAJCQljb250aW51ZTsKIAkJLyogQ2hlY2sgZm9yIG1hZ2lj ICovCi0JCWlmIChmcy0+ZnNfbWFnaWMgPT0gRlNfVUZTMV9NQUdJQyAmJiBmcy0+ZnNfZnNp emUgPiAwKSB7Ci0JCSAgICAJLyogVmFsaWQgVUZTMS4gKi8KLQkJfSBlbHNlIGlmIChmcy0+ ZnNfbWFnaWMgPT0gRlNfVUZTMl9NQUdJQyAmJiBmcy0+ZnNfZnNpemUgPiAwKSB7Ci0JCSAg ICAJLyogVmFsaWQgVUZTMi4gKi8KLQkJfSBlbHNlIHsKKwkJc3dpdGNoIChmcy0+ZnNfbWFn aWMpIHsKKwkJY2FzZSBGU19VRlMxX01BR0lDOgorCQljYXNlIEZTX1VGUzJfTUFHSUM6CisJ CQlpZiAoZnMtPmZzX2ZzaXplID4gMCkgeworCQkJCWlmICh3aGF0ID09IEdfTEFCRUxfVUZT X1ZPTFVNRSkKKwkJCQkJYnJlYWs7CisJCQkJZnNfc2l6ZSA9IChmcy0+ZnNfbWFnaWMgPT0g RlNfVUZTMV9NQUdJQykgPworCQkJCSAgICBmcy0+ZnNfb2xkX3NpemUgOiBmcy0+ZnNfc2l6 ZTsKKwkJCQlpZiAocHAtPm1lZGlhc2l6ZSAvIGZzLT5mc19mc2l6ZSA9PSBmc19zaXplKQor CQkJCQlicmVhazsKKwkJCX0KKwkJCS8qIEZBTExUSFJPVUdIICovCisJCWRlZmF1bHQ6CiAJ CQlnX2ZyZWUoZnMpOwogCQkJY29udGludWU7CiAJCX0K --------------030401010906040706090801--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FBEB386.7000503>