From owner-cvs-all@FreeBSD.ORG Wed Jun 23 01:47:12 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF83716A4CE; Wed, 23 Jun 2004 01:47:12 +0000 (GMT) Received: from exchhz01.viatech.com.cn (ip-40-162-97-218.anlai.com [218.97.162.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id E64A543D2F; Wed, 23 Jun 2004 01:47:08 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from freebsd.org (DAVIDWNT [10.4.1.99]) by exchhz01.viatech.com.cn with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id NAMYXA1R; Wed, 23 Jun 2004 09:45:51 +0800 Message-ID: <40D8E168.4050007@freebsd.org> Date: Wed, 23 Jun 2004 09:48:24 +0800 From: David Xu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030723 Thunderbird/0.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <200406211403.i5LE3cJR022889@repoman.freebsd.org> In-Reply-To: <200406211403.i5LE3cJR022889@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2004 01:47:12 -0000 Bruce Evans wrote: >bde 2004-06-21 14:49:50 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_exit.c > Log: > (1) Removed the bogus condition "p->p_pid != 1" on calling >sched_exit() > from exit1(). sched_exit() must be called unconditionally from >exit1(). > It was called almost unconditionally because the only exits on >system > shutdown if at all. > > (2) Removed the comment that presumed to know what sched_exit() does. > sched_exit() does different things for the ULE case. The call >became > essential when it started doing load average stuff, but its caller > should not know that. But this change loses a semantic, in most time, init is waitting there to recycle runnaway processes, those process were not created by init, if you call sched_exit for init unconditionally, the runnaway process's cpu usage are all merged into init, this is unfair for init, is there any benifit to lower init's priority under load to slow down recycling speed ? I don't think so. I think scheduler's sched_exit should be fixed at same time to keep this semantic. David Xu