From owner-svn-src-all@FreeBSD.ORG Wed Oct 1 21:21:56 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BB1C4718; Wed, 1 Oct 2014 21:21:56 +0000 (UTC) Received: from mail-ie0-x236.google.com (mail-ie0-x236.google.com [IPv6:2607:f8b0:4001:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 758D5C15; Wed, 1 Oct 2014 21:21:56 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id rp18so1262812iec.41 for ; Wed, 01 Oct 2014 14:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=r2K+/f0uOXmEDUbYDfZzdlWyWhYu1uu8in5uPB0KN14=; b=jrAWph9OAEikgMZf5LQYdksC95ihyZAsuEa/pxvVDXwyWRJ7Z6NIH1msQu18gzeMmU uWz2qjsc7wyVGaY2BPZaV9UAnb1ZFwnLcCwkxoFMJt9qS6nu1hOpvHr/zO6Aa9zcaW7y PNb3tnpo1++eGuUEc+yvicVXrPerAnkRBQcISViUVEDiGGvYGdOj1YS/YQAsqlJvaz8h +5dxchRQ9/58iAqncDNlUnAZvPENXwJeNJdPey9eBJQQq6YcQ1DB4qd0GlXOjp4n6MGT 4NkzIIL8oaGqr+PR8Qpb12uH7q5m3VFiwsABVQtaHV31VMe0JIs5FY0zaIJPgmqlEGVX og6g== MIME-Version: 1.0 X-Received: by 10.42.212.7 with SMTP id gq7mr4626064icb.28.1412198515747; Wed, 01 Oct 2014 14:21:55 -0700 (PDT) Received: by 10.50.227.42 with HTTP; Wed, 1 Oct 2014 14:21:55 -0700 (PDT) In-Reply-To: References: <201409291505.s8TF5Nhh066884@svn.freebsd.org> Date: Wed, 1 Oct 2014 14:21:55 -0700 Message-ID: Subject: Re: svn commit: r272282 - head/share/mk From: NGie Cooper To: Will Andrews Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 21:21:56 -0000 On Wed, Oct 1, 2014 at 1:16 PM, Will Andrews wrote: > On Wed, Oct 1, 2014 at 2:03 PM, NGie Cooper wrote: >> This change seems like it introduces a lot of unnecessary complexity >> in lieu of someone setting PORTSDIR to the root of their ports tree in >> the environment. > > Sure, but people that are trying to use it somewhere other than > /usr/ports shouldn't be surprised by misbehavior. I've worked with > several people (who aren't steeped in the usage of ports) who were > astonished by this behavior. Sounds like a documentation issue though (it's not listed in the handbook :(..: https://www.freebsd.org/doc/handbook/ports-using.html ) >> Why isn't it using a for-loop by the way? > > My original implementation used a shell for loop (see the CR), but > given the lack of a legitimate use case for looking farther up than > three parent directories, it seemed easier not to. I suppose one > could use a static list of paths in the for loop though. Yep -- that's what I meant :). Thanks!