From owner-freebsd-ports Mon Sep 28 17:50:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA06076 for freebsd-ports-outgoing; Mon, 28 Sep 1998 17:50:09 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA06068 for ; Mon, 28 Sep 1998 17:50:06 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id RAA04208; Mon, 28 Sep 1998 17:50:01 -0700 (PDT) Received: from axl.training.iafrica.com (axl.training.iafrica.com [196.31.1.175]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA05646 for ; Mon, 28 Sep 1998 17:45:50 -0700 (PDT) (envelope-from sheldonh@axl.training.iafrica.com) Received: from sheldonh by axl.training.iafrica.com with local (Exim 2.02 #1) id 0zNnv4-00059Y-00 for FreeBSD-gnats-submit@freebsd.org; Tue, 29 Sep 1998 02:45:34 +0200 Message-Id: Date: Tue, 29 Sep 1998 02:45:34 +0200 From: axl@iafrica.com Reply-To: axl@iafrica.com To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: ports/8080: ports/security/crack/Makefile broken Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 8080 >Category: ports >Synopsis: ports/security/crack/Makefile broken >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Sep 28 17:50:01 PDT 1998 >Last-Modified: >Originator: Sheldon Hearn >Organization: UUNET Internet Africa >Release: FreeBSD 2.2.7-STABLE i386 >Environment: Ports >Description: The Makefile for the crack port appears to be broken. I must assume that the only people who use it either don't use this port or don't use DES, because I can't see how it works when USE_DES is defined. >How-To-Repeat: cd ${PORTSDIR}/security/crack ; make clean ; make The following is an abridged script(1) session: Script started on Tue Sep 29 02:20:25 1998 [...snip...] ===> Building for crack-5.0 [...snip...] + [ -d ../libdes ] + cd ../libdes + make [...snip...] cc -g -O -DUSE_STRING_H -DUSE_STDLIB_H -DUSE_SIGNAL_H -DUSE_SYS_TYPES_H -DUSE_UNISTD_H -DUSE_PWD_H -I../lib -o ../../run/bin/freebsd-2-i386_/dictfilt dictfilt.c elcid.o ../../run/bin/freebsd-2-i386_/libc5.a elcid.c:159: Undefined symbol `_crypt' referenced from text segment *** Error code 1 Stop. *** Error code 1 Stop. Script done on Tue Sep 29 02:21:39 1998 The following change to Makefile appears to be fairly logical and results in a clean build. I'm not sure whether this is the right solution, though. Perhaps crack should be using the stuff in the secure distribution instead of its own stuff? Basically, if this is a simple one-line ommission in the Makefile, great. If it's a more complex issue, please let me know and I'll look at what's going on more closely. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/security/crack/Makefile,v retrieving revision 1.6 diff -u -d -r1.6 Makefile --- Makefile 1997/11/26 01:42:55 1.6 +++ Makefile 1998/09/29 00:22:40 @@ -26,6 +26,7 @@ @/bin/mv -f ${WRKSRC}/src/libdes ${WRKSRC}/src/libdes.notused @/bin/mv -f ${WRKSRC}/src/util/elcid.c ${WRKSRC}/src/util/elcid.c.orig @${CP} -p ${WRKSRC}/src/util/elcid.c,bsd ${WRKSRC}/src/util/elcid.c +.else @echo "XLIB+= -lcrypt" >> ${WRKSRC}/src/util/Makefile .endif >Fix: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message