From owner-freebsd-current@freebsd.org Wed Jul 17 07:12:03 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E28EFA5322 for ; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C06186B523; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 99787150F9; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 1B7CCC0889; Wed, 17 Jul 2019 09:12:02 +0200 (CEST) Date: Wed, 17 Jul 2019 09:12:02 +0200 From: Baptiste Daroussin To: Eygene Ryabinkin Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190717071201.beem6et6dybhby7m@ivaldir.net> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="725xz2rmc4ukfxl2" Content-Disposition: inline In-Reply-To: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: C06186B523 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2019 07:12:03 -0000 --725xz2rmc4ukfxl2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote: > Good day. >=20 > Attached is the patch that makes built-in tbl(1) processor in mandoc > to avoid dumping core when it renders the table with empty "T{ T}" > block and horizontally-ruled table. >=20 > The simplest way to reproduce the issue is to either > - run 'man notmuch-config' with mail/notmuch installed; > - run 'mandoc tests/empty-table-cdata.1' against the attached > test-only manpage. >=20 > With the patch applied, one can utilize 'make check': regression > test was added. Perhaps an invocation of > {{{ > mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests > }}} > will be needed to run 'make check' without remaking/installing > the world. >=20 > The patch is for the fresh -CURRENT. Be interested in any results > of its application and usage. >=20 > Thanks! >=20 > P.S.: please, CC me: I am not subscribed to the list. > --=20 > Eygene Ryabinkin ,,,^..^,,, > [ Life's unfair - but root password helps! | codelabs.ru ] > [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] Hello, Thank you for the patch! Have it been discussed with upstream? I kind of re= mind something like this being reported to upstream, but I haven't checked the status. Best regards, Bapt --725xz2rmc4ukfxl2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0uykEACgkQY4mL3PG3 PlplQQ/9HfYngYZrPKLVUczfqzkOfZHp/lm0N9QfvGgnuGePAMpiruLyvAF4Iaom g1mKM9FVmga40ccbg+GGeqrdPzqJBExrdgykfaiOYPzadJuuvGKMZTJXcpMUXhOP hasyw+uf8dY+PuA09uvRPhsaqTrHMf+qyKNIj2r+/+MOUV2bk1pRHQVXB7WxcYRm u0/oeW7Kkjm8LyMPR/2MNF4bhx5v4vupZfgXF99v4s3KV6L01BP6+sXNyhg+Pk0O FN+Uwzqq5FTcPFu4I+so8zU7ManuX0NHOGHK9eEIEP65wIh65BTGP2qexWtOsuyv VlOqn/Q4+ZjIACtZPhZx0rjPUOGG8SaqCJc3CS/HTKn4tWOAoPbHOvZT1XFlzmn6 +8kGLqZ9khIEiYfSmDDQxiZV4S1bNoNBDd/16CTFWUfUThJaJUocJ3dnAR4kv6Xq TGLoWtJ7lSqTrcWZMj3ulBv6xqrtsdU63MfFjnYIj2fXWD/cI1X79uMPD0omvQ/9 gtsOKgq8QEipvg2fewg2mdd8bFPNNq8vUZcBZ1sqBJVj8RJMmXJpIfexaWNNXI7a nQtbmal1eLOMvTrZh/W3NRUBKXArF6fTCVJHb5vUfzB6bdIiTR/V90rJVTnJ3afb bTcTENutdicIQlZvHhf761dkgguo9MCs9kK0ahyepLS/9AdBclw= =7Yds -----END PGP SIGNATURE----- --725xz2rmc4ukfxl2--