Date: Thu, 30 May 2013 10:29:33 -0500 From: Brooks Davis <brooks@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251140 - head Message-ID: <20130530152933.GB36644@lor.one-eyed-alien.net> In-Reply-To: <201305301053.23282.jhb@freebsd.org> References: <201305301409.r4UE9wSP009396@svn.freebsd.org> <201305301053.23282.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nVMJ2NtxeReIH9PS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 30, 2013 at 10:53:23AM -0400, John Baldwin wrote: > On Thursday, May 30, 2013 10:09:58 am Brooks Davis wrote: > > Author: brooks > > Date: Thu May 30 14:09:58 2013 > > New Revision: 251140 > > URL: http://svnweb.freebsd.org/changeset/base/251140 > >=20 > > Log: > > Always define INSTALL_DDIR and define it such that it contains no ext= ra > > / characters rather than removing them later on. This should fix > > release builds. > > =20 > > PR: conf/178963 > > Reviewed by: gjb, hrs > >=20 > > Modified: > > head/Makefile.inc1 > >=20 > > Modified: head/Makefile.inc1 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Makefile.inc1 Thu May 30 14:07:14 2013 (r251139) > > +++ head/Makefile.inc1 Thu May 30 14:09:58 2013 (r251140) > > @@ -522,7 +523,7 @@ _includes: > > @echo "--------------------------------------------------------------" > > @echo ">>> stage 4.1: building includes" > > @echo "--------------------------------------------------------------" > > - ${_+_}cd ${.CURDIR}; ${WMAKE} SHARED=3Dsymlinks par-includes > > + ${_+_}cd ${.CURDIR}; ${WMAKE} par-includes > > _libraries: > > @echo > > @echo "--------------------------------------------------------------" >=20 > Did you mean to change this? It seems unrelated. Oops, I forgot that I had that in for testing. Reverted in 251141. That said, the SHARED=3D(copies|symlinks) code should probably go on the chopping block. It's a lousy idea except for populating WORLDTMP and here it saves at most 1.5% in /usr/obj. Worse, the implementation is hand coded in each Makefile so it adds complexity for a mostly useless feature. -- Brooks --nVMJ2NtxeReIH9PS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFRp3BdXY6L6fI4GtQRAm5/AJ47DB36CE0dJmFnDGZaUroYGAhhMwCgqCr2 zgUi+OupTRTuB5zOgeyiGMw= =Qqsd -----END PGP SIGNATURE----- --nVMJ2NtxeReIH9PS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130530152933.GB36644>