From nobody Tue Sep 23 17:18:47 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWRXV1xpBz68tSJ; Tue, 23 Sep 2025 17:18:50 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWRXT73TMz3Cmg; Tue, 23 Sep 2025 17:18:49 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758647930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/lHV9XLZh+mhz9T6Hjd4krdEt7DaHGGyzqMmTOYM2iU=; b=pv5xSiLQUeP9XH0GSj1YU8cvFfjM2nnxw9NJQOSGcWQNMHugmzb6KyBc7gvh2xOp8pagwm ho/6W0SkWqXz9NjeqOhcbIsurS68vOe3vA85lgDXYvy/7km/tMZ3Dnu/dOWupWt2Yv3GuM NBgkUb7FwpjQP+Uk+PYOI91PLvMpooD92ScgCcJQKoYoHOLYnTiFUpl5IG3cXW0XBZiLSF AT+jGeHjDxZocUS2ptC2HbfmtaMgjUY/sQVhCcFBkrnxrDkqsR5zZ6Q7D+8GjbkJaDP+7Q Li+nkggXyXbRacpeNG8MJpdzRIsoltfWF/oE/XeX1DdtUg57iacJjWlwp7JZpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758647930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/lHV9XLZh+mhz9T6Hjd4krdEt7DaHGGyzqMmTOYM2iU=; b=C9TtZ0hgfaMzKBmvmGFsBxV8hlnZTLG7mAxAstt+3Wd6ob62gijfIFPOysVijlamfm2+ZM NT+jyzU8qFbRQpZT+5wjLo4nuGFuIEnUTEMzAjewwxvkZAZIZDkfwDLb6BLaNfMWwNRC3l 8WYz8JlOZX87VOTFG9TFU/B0NwlHdBbY3chbNxMxwR3I2jdXEKGLqiXQyF0muoEOle1gig Wf6yio/C/pRTj//cCa4E8Ou9TQKUNRdXtpNTqCdy2b9W4gsuAL6LIWD9Za8RuQVu1PjsRR M4n80Udyfbp8ka9zoNZUoV2wlUMfjDAw7zTuluC44csTH0GAQG8a7UEC2Ok7AA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758647930; a=rsa-sha256; cv=none; b=Qq+9xdOxJ3oJsEZiqe5XcNoTFWqr7v+CEoxaUnxYLHmecODKWNI/PN7IEybC4RpU1SmOAA 62vDyO2qcNQdCx+GDS61SLYnXamEJMax1wSRJWkH6nd1gtwFB5Ltnnzs+OrjHX990zx+1z Hd0PAwvwFnDXqKEMP5VCosERmfuanrIAg+Xe3baiZW+Uv1GZ3hNmd2mMc6NgE9vHAhlrMe l+Ntt36B+in5iJBmmb35MsWbKsZ8rgiM6O7DOsuNt0tiPWNV91PqgWqPdKLT94luijB66G 54tt1XG0iY1jG6zmNOjJUdIqsF53NXZprAYJ+jp9wWLbYdEqOWKUiP1v1GPYSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2a01:e11:2002:4280::13:1] (unknown [IPv6:2a01:e11:2002:4280::13:1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cWRXT29m0z1Rrk; Tue, 23 Sep 2025 17:18:49 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <997869ae-377b-493b-bedb-19b89a888381@FreeBSD.org> Date: Tue, 23 Sep 2025 19:18:47 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Guido Falsi Subject: Re: git: 0ec13430c583 - main - sys/netinet6: Fix ABI breakage introduced with RFC 7217 support To: Zhenlei Huang Cc: "Jonathan T. Looney" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509220759.58M7xkrM031432@gitrepo.freebsd.org> <6c318ff2-48af-4d8d-8f0f-eea629f42e62@FreeBSD.org> <6657C773-2A9B-4C76-BAAC-E3CCE69CA5D1@FreeBSD.org> Content-Language: en-US, it, en-GB Autocrypt: addr=madpilot@FreeBSD.org; keydata= xsBNBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAHNIkd1aWRvIEZhbHNpIDxtYWRwaWxvdEBGcmVlQlNELm9yZz7CwHgEEwECACIFAk+G+3MC GwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEBrmhg5Wy9KT2uIIAIrawQ89TnqEhi2C OEQAhx3uqWZuNoS6NyiSgsRCmtSnT2GOgH4Ucbr/I37SkV1B3K6HkoL6lwN8Gjf5KOgLqmTi E1W3RTwS7l8PSvdnjM9i7g351R4mTijtxawB/JcQf/Kge3Yqr1V4g6H+wQXHUStmHThbupuN trzRphvR/e5ekT0FTyVfPmpcbm68i2bwZnKUex/TNIECBykYh8b+SYMLhENf2ayRjCIWS2Ad 7tnTKhMtnS5jtW6qjBy4RoTpQD6oR1xIgkTRlQ49roVCUfdHb+Y/kh+U9G1IcoNy4vkg9IfP dwpSfnP+a8j0AZ1hMnOLZ1fYoQrs+4gVLy8Fs7TOwU0EUxB7QQEQAKFhrDceoPdK/IHDSmoj 6SQYisvM7VdhcleS7E9DoEAVt7yMbf6HbbMVTTY6ckvwTWQssywLBXNVqxgc4WLJjzfUhgef +WE75M3+WFYlOVQLGZY/zEVgma1raYnOHNAOzeHLDmEXjbZP6vGAeDyBbGfQPpE7qGYZ7ube T3XwQO+PklcCrvOPj2ZPcAxGNS2xVU/LzONqCrJqLMJSIcCdsbiSP4G5PnDFHtMokaTY6OEr 8OEQfOAerhcHUa/z7Uu8YtmaqKH+QGkE/WEgaRqSiTnv0JOTD+DxehaqvoKPPZ++2NpCZMHB 2i6A/xifmQwEiIjEXtcueBRzkNUQkxhqZyS13SrhocL9ydtaVPBzZatAEjUDDEJmAMLVFs45 qfyhMiNapHJo2n3MW/E5omqCvEkDdWX/en3P7CK2TemeaDghMsgkNKax/z0wNo5UZCkOPOz0 xpNiUilOVbkuezZZNg65741qee2lfXhQIaZ66yT7hphc/N/z3PIAtLeze4u1VR2EXAuZ2sWA dlKCNTlJMsaU/x70BV11Wd/ypnVzM68dfdQIIAj1iMFAD/lXGlEUmKXg5Ov2VQDlTntQoanC YrAg+8CttPzjrydgLZFq3hrtQmfc0se5yv1WHS69+BsUOG09RvvawUDZxUjW19kyeN9THaNR gow3kSuArUp6zSmJABEBAAHCwF8EGAEIAAkFAlMQe0ECGwwACgkQGuaGDlbL0pMN5wgA4bCk X/qwEVC06ToeR6C2putmSWQMgpDaqrv65Hubo+QGmg2P4ewTYQQ4g6oYWS03qHxqVVWhKz7F jfrV+dH8qbCLfSgIcvdBha7ayGZVrsiuMLKGbw36fcmkZPpSDOfHcP0XH8Z+u9CWj0xUkTxA lZ/7i6gYSUpG2JWNtdmE/X8VVEyXusCLwy0K0BI60A/4dRTIX3C4QKrJ3ZbUXegz70ynjHf+ lQMZ9IZKASoRMuS5FozPQh6abvmwZEPdf5I9riUElzvHrqJ8Bx0t3Pujdoth+yNHpnBxrtO8 LkQdrQ58P0SwcaIX33T2U9pG8bhu5YVR88FQ8OQ0cEsPBpDncg== In-Reply-To: <6657C773-2A9B-4C76-BAAC-E3CCE69CA5D1@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/23/25 18:16, Zhenlei Huang wrote: > > >> On Sep 23, 2025, at 11:48 PM, Guido Falsi wrote: >> >> On 9/23/25 17:27, Jonathan T. Looney wrote: >>> On Mon, Sep 22, 2025 at 11:44 AM Guido Falsi > wrote: >>> On 9/22/25 17:37, Jonathan T. Looney wrote: >>> > This seems like it is probably a low-frequency event. If so, why >>> is a >>> > counter a better choice for this than an atomic? >>> > >>> I used counters because they were already being used in the netinet6 >>> code, and are a good match for the use. >>> What makes them a good match for the use? Counters are generally best for write-often, read-rarely (by comparison) things, like statistics, where we want to avoid contention in a often-used critical path. For low-frequency events, the expense of keeping the counters (memory usage multiplied by the number of cores; more difficult debugging; etc.) may outweigh the benefits. >> >> Maybe I explained myself poorly, I meant to say the structure already uses counters and they work. > > Jonathan is not talking about the correctness but he hints it is overkill to use a counter(9) for a rarely updated struct member. > >> >> It did not occur to me to use something different, but I see no problem using a different tool, as long as it works and does not make the logic more complex. > > An atomic(9) is sufficient, so you can eliminate alloc / free and the code is shorter :) Thanks for the clarification. I'll take a look then, if the code can be improved I'm all in favour of that. -- Guido Falsi