From owner-svn-ports-head@freebsd.org Sun Jun 30 09:13:59 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C38E915D0F46; Sun, 30 Jun 2019 09:13:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 687C7777EA; Sun, 30 Jun 2019 09:13:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4010646C5; Sun, 30 Jun 2019 09:13:59 +0000 (UTC) Date: Sun, 30 Jun 2019 09:13:59 +0000 From: Alexey Dokuchaev To: Matthias Fechner Cc: Torsten Zuehlsdorff , Palle Girgensohn , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505245 - in head/databases: postgresql10-client postgresql10-contrib postgresql10-pgtcl postgresql10-server postgresql11-client postgresql11-server postgresql94-server postgresql95-cli... Message-ID: <20190630091359.GB59213@FreeBSD.org> References: <201906272128.x5RLS0Uv072609@repo.freebsd.org> <899f2367-828a-9eca-dfaa-e34a039fcdac@toco-domains.de> <20190629155606.GB97932@FreeBSD.org> <6ff9ed1f-1597-bc72-6ed2-e0bb634af8f7@fechner.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ff9ed1f-1597-bc72-6ed2-e0bb634af8f7@fechner.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 687C7777EA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.961,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2019 09:13:59 -0000 On Sat, Jun 29, 2019 at 07:14:11PM +0200, Matthias Fechner wrote: > Am 29.06.2019 um 17:56 schrieb Alexey Dokuchaev: > > We're using Postres in our production at $work and had to carefully evaluate > > all 9.x versions, so it looks strange the GitLab works with 9.6 but not with > > 9.5, as changes between these should be pretty minor AFAIR (in comparison to > > e.g. 9.3). May we know what exactly breaks, so maybe we can craft a patch > > to fix it? > > I do not fully remember what it was, but they use a feature that was > added with 9.6 (used to retrieve data from the database with a more > complex query): > https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/requirements.md#postgresql-requirements > > If you would like to have more details, there is an issue existing that > describe why 9.6 is required in detail, but I do not have the link anymore. > Maybe it is easier to check what new feature was added with 9.6. I tried to see what had changed but could only find version bump from 9.2 to 9.6 in commits like these: https://gitlab.com/gitlab-org/gitlab-ce/commit/b609c8f650ca9854d12edbf623f2419c216e73a7 https://gitlab.com/gitlab-org/gitlab-ce/commit/e1294022875138b40db7d34a9f33ac9f4a7dc655 I'd try to lower those number to 9.5, I'd expect with high probability things would work just as fine. > If you run FreeBSD at $work you should anyway have your own poudriere > build package repository where you have your tested packages in. > So you can set there in make.conf > DEFAULT_VERSIONS=pgsql=9.4 Unfortunately, we don't use FreeBSD at $work, but since PG provide their own packages for a vast variety of versions, there're no problems. > So we should not block here to go to a more recent version. Yeah, which is, like, 10.x. :-) ./danfe