From owner-svn-src-all@FreeBSD.ORG Wed Apr 8 08:48:42 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 55358376; Wed, 8 Apr 2015 08:48:42 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D342522B; Wed, 8 Apr 2015 08:48:41 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t388mdOc096352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 8 Apr 2015 11:48:39 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t388mdwr096351; Wed, 8 Apr 2015 11:48:39 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 8 Apr 2015 11:48:39 +0300 From: Gleb Smirnoff To: Adrian Chadd Subject: Re: svn commit: r281239 - head/sys/netinet Message-ID: <20150408084839.GO64665@FreeBSD.org> References: <201504072309.t37N9Zwf011383@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201504072309.t37N9Zwf011383@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 08:48:42 -0000 On Tue, Apr 07, 2015 at 11:09:35PM +0000, Adrian Chadd wrote: A> Author: adrian A> Date: Tue Apr 7 23:09:34 2015 A> New Revision: 281239 A> URL: https://svnweb.freebsd.org/changeset/base/281239 A> A> Log: A> Move the IPv4 reassembly queue locking from a single lock to be per-bucket (global). A> A> This significantly improves performance on multi-core servers where there A> is any kind of IPv4 reassembly going on. A> A> glebius@ would like to see the locking moved to be attached to the reassembly A> bucket, which would make it per-bucket + per-VNET, instead of being global. A> I decided to keep it global for now as it's the minimal useful change; A> if people agree / wish to migrate it to be per-bucket / per-VNET then please A> do feel free to do so. I won't complain. A> A> Thanks to Norse Corp for giving me access to much larger servers A> to test this at across the 4 core boxes I have at home. A> A> Differential Revision: https://reviews.freebsd.org/D2095 A> Reviewed by: glebius (initial comments incorporated into this patch) No, they are not. Also, I just noticed another issue with the patch. You initialize the mutexes, which are global, in the ip_init() which is called for every VNET. That would lead to panic of initializing already initialized mutex. If you followed my advice, that would not happen. Now VIMAGE+INVARIANTS is broken instantly, and w/o INVARIANTS may panic if VIMAGE created under IP traffic. My comment that purging from a bucket that is determined by source IP has security implications was also ignored. I will fix this all myself. -- Totus tuus, Glebius.