From owner-freebsd-wireless@FreeBSD.ORG Thu May 8 16:43:17 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9045E3C1 for ; Thu, 8 May 2014 16:43:17 +0000 (UTC) Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com [IPv6:2607:f8b0:400d:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47C9D826 for ; Thu, 8 May 2014 16:43:17 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id x13so3221543qcv.30 for ; Thu, 08 May 2014 09:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rCSiL862vnlwFDjGOCQQbhkEhZh48SIdvSnFqBndDuM=; b=mlYe/3PpReqUv7rLiwd6+7j5pEiSqh+TPQMycba17ulP2MqVyCTE5nYqaHiKqWQH8U ibS3X2IZ35cpeHruTUI7Ji6/Usme74yXH2NtiyDRwkKA722KS9mgnvoONJ7VyQ4blw+i wSIU+T317KS1xN1wchsSwdpxhOtxjDh8x6iTbJOAansyyzvMAq4lcETbcxGRtw1qmqVb e9YMux8kTkQIdcY/sDRLbgYKrc+2r18Mqnii+zQVyngtzQdKABbXSGvxqzy3vXZ3Yza4 a/X+kFB0P2tsHH5r2S3QDLjI57tC4K8r4+91lA+NxZHtJp5Omxit4f5Nk6UHJCXVIlwy C0HA== MIME-Version: 1.0 X-Received: by 10.224.129.66 with SMTP id n2mr6587118qas.55.1399567395787; Thu, 08 May 2014 09:43:15 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.191.201 with HTTP; Thu, 8 May 2014 09:43:15 -0700 (PDT) In-Reply-To: <14909.1399545008@elam.kais.kyoto-u.ac.jp> References: <20140226123709.GA31099@syn.pertho.net> <530EE7F4.3080903@shurik.kiev.ua> <24791.1393550277@elam.kais.kyoto-u.ac.jp> <75498.1398751548@elam.kais.kyoto-u.ac.jp> <84650.1398819225@elam.kais.kyoto-u.ac.jp> <14909.1399545008@elam.kais.kyoto-u.ac.jp> Date: Thu, 8 May 2014 09:43:15 -0700 X-Google-Sender-Auth: IRHVhGf22K7AKiw5cznO85-ek9w Message-ID: Subject: Re: Centrino Wireless-N 1000 support is also broken (Re: iwn(4) in -HEAD supporting Centrino Wireless-N 135) From: Adrian Chadd To: Kaho Toshikazu Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 16:43:17 -0000 Hi! Cool! So what's the value of txchainmask and rxchainmask from the EEPROM? before things get overridden? I'd like to figure out what that changed. Thanks! -a On 8 May 2014 03:30, Kaho Toshikazu wrote: > Hello adrian, > > Thank you for a patch, and I'm sorry for late reply. > Your patch fixes the problem. ".calib_need" flag's change helps. > Other changes doesn't need to fix, but they doesn't > seem to make any problem. > > The minimum necessary change is below. > if_iwn.c : no change > if_iwn_chip_cfg.h: remove IWN_FLG_NEED_PHY_CALIB_DC, > add IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC > > > Index: if_iwn_chip_cfg.h > =================================================================== > --- if_iwn_chip_cfg.h (revision 265665) > +++ if_iwn_chip_cfg.h (working copy) > @@ -219,8 +219,9 @@ > .regulatory_bands = iwn5000_regulatory_bands, > .enhanced_TX_power = false, > .calib_need = > - ( IWN_FLG_NEED_PHY_CALIB_DC > - | IWN_FLG_NEED_PHY_CALIB_LO > + ( > + IWN_FLG_NEED_PHY_CALIB_LO > + | IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC > | IWN_FLG_NEED_PHY_CALIB_TX_IQ > | IWN_FLG_NEED_PHY_CALIB_BASE_BAND ), > .support_hostap = false, > > -- > Kaho Toshikazu > > > Adrian Chadd wrote: > >> Hi! >> >> Would you mind trying this? >> >> What values do you have for sc_txchainmask and sc_rxchainmask? Before >> they're over-ridden? >> >> Thanks! >> >> >> -a >> >> adrian@sabrina:~/work/freebsd/head/src/sys/dev/iwn % svn diff . >> Index: if_iwn.c >> =================================================================== >> --- if_iwn.c (revision 265478) >> +++ if_iwn.c (working copy) >> @@ -744,6 +744,8 @@ >> sc->limits = &iwn1000_sensitivity_limits; >> sc->base_params = &iwn1000_base_params; >> sc->fwname = "iwn1000fw"; >> + /* XXX override chainmasks? */ >> + sc->txchainmask = IWN_ANT_AB; >> break; >> default: >> device_printf(sc->sc_dev, "adapter type id : 0x%04x sub id :" >> Index: if_iwn_chip_cfg.h >> =================================================================== >> --- if_iwn_chip_cfg.h (revision 265478) >> +++ if_iwn_chip_cfg.h (working copy) >> @@ -219,14 +219,18 @@ >> .regulatory_bands = iwn5000_regulatory_bands, >> .enhanced_TX_power = false, >> .calib_need = >> - ( IWN_FLG_NEED_PHY_CALIB_DC >> + ( >> +// IWN_FLG_NEED_PHY_CALIB_DC >> | IWN_FLG_NEED_PHY_CALIB_LO >> + | IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC >> | IWN_FLG_NEED_PHY_CALIB_TX_IQ >> - | IWN_FLG_NEED_PHY_CALIB_BASE_BAND ), >> + | IWN_FLG_NEED_PHY_CALIB_BASE_BAND >> + ), >> .support_hostap = false, >> .no_multi_vaps = true, >> .additional_gp_drv_bit = IWN_GP_DRIVER_NONE, >> - .bt_mode = IWN_BT_NONE, >> +// .bt_mode = IWN_BT_NONE, >> + .bt_mode = IWN_BT_SIMPLE, >> .plcp_err_threshold = IWN_PLCP_ERR_EXT_LONG_THRESHOLD, >> }; >> static const struct iwn_base_params iwn_6000_base_params = {