From owner-svn-src-head@freebsd.org Fri Nov 17 20:30:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FA4CDE2A65 for ; Fri, 17 Nov 2017 20:30:15 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B15367488E for ; Fri, 17 Nov 2017 20:30:14 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22d.google.com with SMTP id y80so8703571wmd.0 for ; Fri, 17 Nov 2017 12:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fU4Aa2rAXXPcSj63jJm8ibF6bJqKP218j2iGa8HuWHw=; b=JsjX+BtCyHjmAnNmbP3jVe3gDKqAJTiAeQFa/jTYZNzRD9l/Uciv5NA12CKEZ03h8F 3WG4DAAYKfJXRY3p1KR823X52582fijTdgL9mnNraf566tK8YHDXt4c2EUbmlEB8oz8b 9JRagGVXLUlfqxo9aHY79NWl+axFBd0iAof9L6AB6K2QzTwxl9F/bbQT/4BiLeICBlpB 2WZ/E3dOFN15nUBQrPr+43OWwCwCMzZn8dxXMvc6LaqPFElZLw/3aGZWbobGHhGiWaVL M+HllbPcEacnU5qKmwhtexvyAttDy//72UahoH7wjU89Z55Zuabc97TWNk9SamROCv3i THGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fU4Aa2rAXXPcSj63jJm8ibF6bJqKP218j2iGa8HuWHw=; b=oroFUQ7Jny5Qz2blem3mW1w2dIMix/zdUEkX1w8De7QfSU7oaYh517qGgWYr60uwSa S4e9YBMKzOMt1ywestHFaPxkKpJV1hKR+ALoykpoegFkj1g+FHuIsBgrSBuLYE5HqVMm pORCUmmgdQU0mu1KHzDrVULr/fvW0b6ppHMcA7sa2aKtOCqdZbeAtqFdRyYTzjeBlK7h f/7Qo0ZjwxzIMB8W717Dg2oAf8N05GJ1oJ5fHaV/NCrmqkgB8+6P9ki4o21HBNL8jtt7 5agN/WESyVuEAaaGQgFn5w3Y525YnOIydva9VZre1Gb7DXJaEidp/dF7/bS0TqUd+6NC sdrg== X-Gm-Message-State: AJaThX5nQUQkOlpUnIsGUNsBMmUrvc6u5L/1pWKV4JhaE35XIRvvyE3p Jx8ZlpidSfWUc/XNY+YwsolioxVnMyO/2RtaYmdI4g== X-Google-Smtp-Source: AGs4zMblklPC8vXtaEilBVV1YO+L156A/9GLVEsrodcZ1E4p13wnamL+Zo0Zo7uv+sQgbsdIbhlGF2HOawVQKNrV1kI= X-Received: by 10.80.142.88 with SMTP id 24mr9340419edx.153.1510950612626; Fri, 17 Nov 2017 12:30:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.149.174 with HTTP; Fri, 17 Nov 2017 12:30:12 -0800 (PST) In-Reply-To: <201711171925.vAHJPeuN074946@repo.freebsd.org> References: <201711171925.vAHJPeuN074946@repo.freebsd.org> From: Oliver Pinter Date: Fri, 17 Nov 2017 21:30:12 +0100 Message-ID: Subject: Re: svn commit: r325957 - in head: sys/kern tests/sys/vfs To: Conrad Meyer Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 20:30:15 -0000 On Friday, November 17, 2017, Conrad Meyer wrote: > Author: cem > Date: Fri Nov 17 19:25:39 2017 > New Revision: 325957 > URL: https://svnweb.freebsd.org/changeset/base/325957 > > Log: > vfs_lookup: Allow PATH_MAX-1 symlinks > > Previously, symlinks in FreeBSD were artificially limited to PATH_MAX-2. > > Add a short test case to verify the change. > > Submitted by: Gaurav Gangalwar > Reviewed by: kib > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D12589 > > Added: > head/tests/sys/vfs/lookup_test.sh (contents, props changed) > Modified: > head/sys/kern/vfs_lookup.c > head/tests/sys/vfs/Makefile > > Modified: head/sys/kern/vfs_lookup.c > ============================================================ > ================== > --- head/sys/kern/vfs_lookup.c Fri Nov 17 19:10:10 2017 (r325956) > +++ head/sys/kern/vfs_lookup.c Fri Nov 17 19:25:39 2017 (r325957) > @@ -499,7 +499,7 @@ namei(struct nameidata *ndp) > error = ENOENT; > break; > } > - if (linklen + ndp->ni_pathlen >= MAXPATHLEN) { > + if (linklen + ndp->ni_pathlen > MAXPATHLEN) { > if (ndp->ni_pathlen > 1) > uma_zfree(namei_zone, cp); > error = ENAMETOOLONG; > > Modified: head/tests/sys/vfs/Makefile > ============================================================ > ================== > --- head/tests/sys/vfs/Makefile Fri Nov 17 19:10:10 2017 (r325956) > +++ head/tests/sys/vfs/Makefile Fri Nov 17 19:25:39 2017 (r325957) > @@ -7,6 +7,8 @@ TESTSDIR= ${TESTSBASE}/sys/vfs > ATF_TESTS_C+= lookup_cap_dotdot > CFLAGS.lookup_cap_dotdot.c+= -I${SRCTOP}/tests > > +#ATF_TESTS_SH+= lookup_test This commented out line is intended? > + > TAP_TESTS_SH+= trailing_slash > > .include > > Added: head/tests/sys/vfs/lookup_test.sh > ============================================================ > ================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/tests/sys/vfs/lookup_test.sh Fri Nov 17 19:25:39 2017 > (r325957) > @@ -0,0 +1,17 @@ > +# $FreeBSD$ > + > +long_symlink_head() > +{ > + atf_set "descr" "Test for 1023 (PATH_MAX-1) symlink support" > +} > +long_symlink_body() > +{ > + atf_check -s exit:0 ln -s aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa sym_long > + # was: "stat: sym_long: stat: File name too long"; exit 1 > + atf_check -s exit:0 -o ignore stat -L sym_long > +} > + > +atf_init_test_cases() > +{ > + atf_add_test_case long_symlink > +} > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org > " >