From owner-freebsd-current@FreeBSD.ORG  Sat Mar 22 23:37:13 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2B4A1065673;
	Sat, 22 Mar 2008 23:37:13 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id ABB748FC1A;
	Sat, 22 Mar 2008 23:37:12 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <47E5982C.5040702@FreeBSD.org>
Date: Sun, 23 Mar 2008 00:37:16 +0100
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
MIME-Version: 1.0
To: Chuck Robey <chuckr@chuckr.org>
References: <47E55BD0.2000101@chuckr.org>	<20080322200225.C32322@fledge.watson.org>
	<47E57717.5060404@chuckr.org>
In-Reply-To: <47E57717.5060404@chuckr.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org, Robert Watson <rwatson@FreeBSD.org>
Subject: Re: patching
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Mar 2008 23:37:13 -0000

Chuck Robey wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Watson wrote:
>> On Sat, 22 Mar 2008, Chuck Robey wrote:
>>
>>> I finally get to the point that I can do some useful coding on some
>>> usb stuff, I make up a patch, update current so that I can compile
>>> against it, and find that someone has broken current.  Naughty,
>>> naughty. Here's the part of kdump where it broke:
>> Since we don't have a sys/tablet, I'm wondering if it's perhaps your
>> fault :-).  Does your include file have appropriate
>> #ifndef/#define/#endif guards around it to protect you from syntax
>> errors in the event of multiple (possibly nested) include?
> 
> Oh, I didn;'t include my patches in what broke, I was trying to get the new
> kernel buoilt and booted first, so whjat broke is 100% just what walked out of
> the archive (I cvsup the cvs archive, not just a checked out image).  Soon as
> this doesn't break on build, I will try my fix to Kai's krepdump USB HID dumping
> module.

<sys/tablet.h> was removed from FreeBSD 8 years ago.  Something is 
seriously out of date on your system.

Kris