From owner-freebsd-ports@FreeBSD.ORG Sun Dec 10 00:42:16 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 29F0316A492; Sun, 10 Dec 2006 00:42:16 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from hub.org (hub.org [200.46.204.220]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD38D43C9E; Sun, 10 Dec 2006 00:41:06 +0000 (GMT) (envelope-from scrappy@hub.org) Received: from localhost (unknown [200.46.204.191]) by hub.org (Postfix) with ESMTP id 99C87118C78A; Sat, 9 Dec 2006 20:42:08 -0400 (AST) Received: from hub.org ([200.46.204.220]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-new, port 10024) with ESMTP id 40609-05; Sat, 9 Dec 2006 20:42:12 -0400 (AST) Received: from ganymede.hub.org (blk-137-79-174.eastlink.ca [24.137.79.174]) by hub.org (Postfix) with ESMTP id 0D680118C757; Sat, 9 Dec 2006 20:42:08 -0400 (AST) Received: from localhost (localhost [127.0.0.1]) by ganymede.hub.org (Postfix) with ESMTP id 40BAB48AA5; Sat, 9 Dec 2006 20:42:16 -0400 (AST) Date: Sat, 09 Dec 2006 20:42:15 -0400 From: "Marc G. Fournier" To: Peter Pentchev , LI Xin Message-ID: In-Reply-To: <20061208200755.GA16586@straylight.m.ringlet.net> References: <4576A4F6.7070407@orchid.homeunix.org> <8194EEE8E22BA574C20015C8@ganymede.hub.org> <4576D15A.2070101@delphij.net> <20061208200755.GA16586@straylight.m.ringlet.net> X-Mailer: Mulberry/4.0.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: freebsd@orchid.homeunix.org, ports@freebsd.org, dd@freebsd.org Subject: Re: bsdstats 5.3 on 6-STABLE and netcat weirdness X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Dec 2006 00:42:16 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 patch committed ... - --On Friday, December 08, 2006 22:07:55 +0200 Peter Pentchev wrote: > On Wed, Dec 06, 2006 at 10:19:06PM +0800, LI Xin wrote: >> Marc G. Fournier wrote: >> > >> > 'k, I don't know how to fix this one ... I thought about doing: >> > >> > .if ${OSVERSION} <= 492101 >> > RUN_DEPENDS= nc:${PORTSDIR}/net/netcat >> > .endif >> > >> > not sure which version brought in nc, but 492101 is the last of the 4.x >> > series ... but it portlint fails miserably if I don't put bsd.port.pre.mk >> > before it, but also fails if I do: >> > >> > WARN: Makefile: no MASTER_SITES found. is it ok? >> > WARN: Makefile: "RUN_DEPENDS" has to appear earlier. >> > 0 fatal errors and 2 warnings found. >> > >> > Is there a better way of doing this ... ? >> >> I think you want something like: >> >> .if ${OSVERSION} < 503102 || (${OSVERSION} >= 600000 && ${OSVERSION} < >> 600010) >> >> instead of just considering 492101. > > That's a good suggestion. > > Mark, as to the portlint problem - well, portlint cannot really be > expected to handle each and every corner case in a port Makefile :) > It is doing a wonderful job as it is, but every now and then you have > to make a choice between a working port and a clean port ;) > > To make the OSVERSION check work, you do indeed need a bsd.port.pre.mk > inclusion before it. Then... just ignore the portlint warnings. > > And... thanks for a great utility! :) > > G'luck, > Peter > > -- > Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org > PGP key: http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 > I am the meaning of this sentence. - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFe1fo4QvfyHIvDvMRAvjnAKCZfqn/io3z0lZ6cP36dlgIsjNiDwCgr0i9 B5SAjpaOL35Dr+XSt6QI5l8= =Eqle -----END PGP SIGNATURE-----