From owner-freebsd-usb@FreeBSD.ORG Thu Jul 19 14:10:19 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 323A416A40A; Thu, 19 Jul 2007 14:10:19 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E3E4813C4B3; Thu, 19 Jul 2007 14:10:18 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l6JE7YXl084869; Thu, 19 Jul 2007 08:07:34 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 19 Jul 2007 08:07:40 -0600 (MDT) Message-Id: <20070719.080740.-861029870.imp@bsdimp.com> To: markhobden@gmail.com From: "M. Warner Losh" In-Reply-To: References: <20070718.203153.112852673.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 19 Jul 2007 08:07:34 -0600 (MDT) Cc: freebsd-current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: uhidev(4) update - USB HID driver level for devices with multiple report ids X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2007 14:10:19 -0000 In message: "Mark Hobden" writes: : On 19/07/07, M. Warner Losh wrote: : > In message: : > "Mark Hobden" writes: : > : I have updated the uhidev(4) patch from NetBSD to apply to today's 7-CURRENT. : > : : > : http://www.terinea.co.uk/~mark/patches/uhidev-7-current-p2.diff : > : > this one seems to be backwards : > : : Sorry Warner, I don't quite get what you mean here. I thought that you'd run the diff backwards. However, I'm wrong.... : Do you mean that the patch is only wanting to apply with patch -R ?? : or does not want to apply in some way? : : or that I have removed the changes made in ums.c version 1.95. : This is the case as the other patch I posted makes them work with : the correct report id. I split up the patches to make it a bit clearer : how the problem is fixed - I am using a WLNOTEBOOK (0x00b9) mouse : right now and they work fine. : : or have I managed remove functionality somewhere else? I haven't reviewed the patch closely, but it is forward and adds a lot... Warner