From owner-svn-src-head@freebsd.org Fri Apr 17 15:54:32 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D2ABB2BE8AA for ; Fri, 17 Apr 2020 15:54:32 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 493gdL24C4z48Xc for ; Fri, 17 Apr 2020 15:54:29 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: (qmail 71698 invoked from network); 17 Apr 2020 15:54:28 -0000 Received: from unknown (HELO exbuntu.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 17 Apr 2020 15:54:28 -0000 Received: (qmail 16148 invoked from network); 17 Apr 2020 15:54:52 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by clamshell.daemonology.net with SMTP; 17 Apr 2020 15:54:52 -0000 Subject: Re: svn commit: r360025 - head/sys/dev/acpica To: Alexey Dokuchaev Cc: Oliver Pinter , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" References: <202004162156.03GLuqgw058432@repo.freebsd.org> <20200417062636.GC24371@FreeBSD.org> From: Colin Percival Autocrypt: addr=cperciva@freebsd.org; prefer-encrypt=mutual; keydata= mQGhBElrAAcRBACDfDys4ZtK+ErCJ1HAzYeteKpm3OEsvT/49AjUTLihkF79HhIKrCQU+1KC zv7BwHCMLb6hq30As9L7iFKG7n5QFLFC4Te/VcITUnWHMG/c3ViLOfJGvi+9/nOEHaM1dVJY D6tEp5yM1nHmVQpo9932j4KGuGFR0LhOK5IHXOSfGwCgxSFDPdgxe2OEjWxjGgY+oV3EafcD +JROXCTjlcQiG/OguQH4Vks3mhHfFnEppLxTkDuYgHZQiUtpcT9ssH5khgqoTyMar05OUdAj ZIhNbWDh4LgTj+7ZmvLhXT5Zxw8LX9d7T36aTB8XDQSenDqEtinMWOb0TCBBLbsB8EFG1WTT ESbZci9jJS5yhtktuZoY/eM8uXMD/3k4FWFO80VRRkELSp+XSy/VlSQjyi/rhl2nQq/oOA9F oJbDaB0yq9VNhxP+uFBzBWSqeIX0t1ZWLtNfVFr4TRP5hihI5ICrg/0OpqgisKsU2NFe9xyO hyJLYmfD8ebpDJ/9k30C7Iju9pVrwLm1QgS4S2fqJRcR+U4WbjvP7CgStCVDb2xpbiBQZXJj aXZhbCA8Y3BlcmNpdmFARnJlZUJTRC5vcmc+iGEEExECACEFAklrAI4CGwMHCwkIBwMCAQQV AggDBBYCAwECHgECF4AACgkQOM7KaQxqam6CdwCfQpS2a4bNO8/PX9hP1YnHE+M8BdwAoLwu CIxGuzK7pNBNUyVMWhy11hH+uQINBElrAAcQCAD3ZLMIsP4CIDoJORg+YY0lqLVBgcnF7pFb 4Uy2+KvdWofN+DKH61rZLjgXXkNE9M4EQC1B4lGttBP8IY2gs41y3AUogGdyFbidq99rCBz7 LTsgARHwFxZoaHmXyiZLEU1QZuMqwPZV1mCviRhN5E3rRqYNXVcrnXAAuhBpvNyj/ntHvcDN 2/m+ochiuBYueU4kX3lHya7sOj+mTsndcWmQ9soOUyr8O0r/BG088bMn4qqtUw4dl5/pglXk jbl7uOOPinKf0WVd2r6M0wLPJCD4NPHrCWRLLLAjwfjrtoSRvXxDbXhCdgGBa72+K8eYLzVs hgq7tJOoBWzjVK6XRxR7AAMGB/9Mo3iJ2DxqDecd02KCB5BsFDICbJGhPltU7FwrtbC7djSb XUrwsEVLHi4st4cbdGNCWCrp0BRezXZKohKnNAPFOTK++ZfgeKxrV2sJod+Q9RILF86tQ4XF 7A7Yme5hy92t/WgiU4vc/fWbgP8gV/19f8nunaT2E9NSa70mZFjZNu4iuwThoUUO5CV3Wo0Y UISsnRK8XD1+LR3A2qVyLiFRwh/miC1hgLFCTGCQ3GLxZeZzIpYSlGdQJ0L5lixW5ZQD9r1I 8i/8zhE6qRFAM0upUMI3Gt1Oq2w03DiXrZU0Fu/R8Rm8rlnkQKA+95mRTUq1xL5P5NZIi4gJ Z569OPMFiEkEGBECAAkFAklrAAcCGwwACgkQOM7KaQxqam41igCfbaldnFTu5uAdrnrghESv EI3CAo8AoLkNMks1pThl2BJNRm4CtTK9xZeH Message-ID: Date: Fri, 17 Apr 2020 08:54:52 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200417062636.GC24371@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 493gdL24C4z48Xc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.95 / 15.00]; TAGGED_RCPT(0.00)[]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.974,0]; ASN(0.00)[asn:14618, ipnet:54.86.0.0/16, country:US]; NEURAL_HAM_LONG(-0.98)[-0.976,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 15:54:32 -0000 On 2020-04-16 23:26, Alexey Dokuchaev wrote: > On Thu, Apr 16, 2020 at 03:12:15PM -0700, Colin Percival wrote: >> On 2020-04-16 15:05, Oliver Pinter wrote: >>> On Thursday, April 16, 2020, Colin Percival >> > wrote: >>> Log: >>> Alert devd when acpi_video brightness changes >>> >>> Please add this to release notes! >> >> I considered that, but so far I don't have any evidence that other >> systems exist with the same half-working ACPI. Unless you're aware of >> people who are seeing the same "hw.apci.video.lcd0.brightness changes >> but thebacklight doesn't" syndrome? > > So this is more like a work-around for the problem which lies elsewhere: > something is missing in acpi_video(4) or perhaps we need a (nonexistent) > acpi_dell(4)? In this case, shouldn't it be disabled by default, or at > least be toggable since as you say, evidently just a minority of systems > exist with the same half-working ACPI? Having occasional extra messages coming through devctl(4) is harmless; by default devd will just drop them on the floor since there isn't anything configured to do with them. In an upcoming change to the graphics/intel-backlight port (if/when someone merges my patch into their github repo...) I'll be providing a configuration file which can be copied into /usr/local/etc/devd/ in order to hook these messages up to the intel-backlight utility. So... yes, for practical purposes this is disabled by default. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid