Date: Mon, 23 Apr 2018 18:27:59 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Yuri <yuri@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468086 - in head/math: . piranha Message-ID: <20180423162759.kw72hqufehzhsu5y@ogg.in.absolight.net> In-Reply-To: <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org> References: <201804230903.w3N93LhK062379@repo.freebsd.org> <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net> <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--lqqxp6rrrzjs6sd3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 23, 2018 at 08:44:15AM -0700, Yuri wrote:
> On 04/23/18 05:37, Mathieu Arnold wrote:
> > Unless this really needs cmake and ninja to run, please reverse the way
> > you create the BUILD_DEPENDS and RUN_DEPENDS variables. You may have
> > noticed many ports do BUILD_DEPENDS=3D${RUN_DEPENDS} and RUN_DEPENDS=3D=
blah.
>=20
>=20
> The way how they defined the build, it does involve cmake. cmake isn't
> "really needed" because cmake doesn't really build anything, but it does
> install it. It is also needed for the 'test' target.
>=20
> You prefer it the way around, "BUILD_DEPENDS=3D${RUN_DEPENDS} and
> RUN_DEPENDS=3Dblah"?
I do not prefer it, I ask for you to change it because what you did is
not correct.
> But doesn't it end up being the same?
No it does not. See other reply.
--=20
Mathieu Arnold
--lqqxp6rrrzjs6sd3
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAABCgBmBQJa3gmPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IB6oP/3o0fASxAaLFYy7EEkFM2nol
W3RZvrNl8Yeqvt2t2uYaLrwoFIA25UDNQ9J7YhgngCyewcJZumL+NDOL4qu559Ao
4h8LDaS0noj/ycoibk5jhzWUHcgsgh/36Faf9yec0uhrJ3SdMgkHHl40lpvCaDiU
2ETNJUnDy2RjixUow6xw/e7NVWSI3wcmGoHy/3ClWjeZA8POKFtaJ50TuFVSCdRB
CMcYYCqLhu1uMm+j3uurdTnwxN4zAqnue1pVAdnqUHG0p5zi207Rg9/z9d9pFrxO
fjnPYwBgHfNCCqdKeLG+agDLs9Zv70RVrD93WV4a8VlVgJm7WEsK4/FHXBqaV3VQ
jsWvKXY2GdKnSzgTifAHpMzdbO2UtxWzdQ0vzZCxpiBPxIacC9QJ4UZarsDcnog5
cvIeRHswI1MxWBBjgAjeUW/caEsfMi3ux3YXPFnPig3O65QvgPQ5VqFVgY4Nizd3
2HzkPAsqk9U845MLAzQ0juzjvAuGYHqmYgrWigx3s+CSEFy5thxs82392PXAfbGk
4r6hg6ACwCeR8mZ2JyWZFOX2R1nztSb433NMhZ1ObN9mck+Owpx2sZJ+ljVVe9xr
ZX3OpEqGzAi7O5J7iw71kD8EiyfkI2Alojo3Y1uY4Lmag2UawRGBa7btuSJ+3OGX
bi2fTtRJApJ5FlR1HQ0t
=37Lm
-----END PGP SIGNATURE-----
--lqqxp6rrrzjs6sd3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180423162759.kw72hqufehzhsu5y>