Date: Tue, 03 Nov 2020 06:33:53 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Mateusz Piotrowski <0mp@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r553975 - head/Mk Message-ID: <202011031433.0A3EXrIE098335@slippy.cwsent.com> In-Reply-To: <202011031005.0A3A5b5e070662@repo.freebsd.org> References: <202011031005.0A3A5b5e070662@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <202011031005.0A3A5b5e070662@repo.freebsd.org>, Mateusz Piotrowski w rites: > Author: 0mp > Date: Tue Nov 3 10:05:37 2020 > New Revision: 553975 > URL: https://svnweb.freebsd.org/changeset/ports/553975 > > Log: > Discourage users from using DO_NADA > > It should not be used to make targets do nothing. In such cases, > it's most likely the ports infrastructure which requires fixing. > > Suggested by: bapt > Approved by: portmgr (bapt) > Differential Revision: https://reviews.freebsd.org/D27072 > > Modified: > head/Mk/bsd.port.mk > > Modified: head/Mk/bsd.port.mk > ============================================================================= > = > --- head/Mk/bsd.port.mk Tue Nov 3 09:27:49 2020 (r553974) > +++ head/Mk/bsd.port.mk Tue Nov 3 10:05:37 2020 (r553975) > @@ -2040,6 +2040,10 @@ STAGE_COOKIE?= ${WRKDIR}/.stage_done.${PORTNAM > E}.${PR > > # How to do nothing. Override if you, for some strange reason, would rather > # do something. > +# In general, however, DO_NADA is a relict of the past in the ports Is the word relict probably a typo? Though the words have similar meaning, relic is probably more appropriate. > +# infrastructure, and most of its usage has been removed. If you need to def > ine > +# a target with DO_NADA, then there is a high chance that the ports > +# infrastructure should be fixed instead. > DO_NADA?= ${TRUE} > > # Use this as the first operand to always build dependency. > -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011031433.0A3EXrIE098335>