From owner-cvs-all  Thu Dec 13  5:45: 0 2001
Delivered-To: cvs-all@freebsd.org
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5E03737BE0F; Thu, 13 Dec 2001 05:43:07 -0800 (PST)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBDDgoi22439;
	Thu, 13 Dec 2001 15:42:50 +0200 (EET)
	(envelope-from ru)
Date: Thu, 13 Dec 2001 15:42:50 +0200
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Sheldon Hearn <sheldonh@starjuice.net>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/smbfs smbfs_vfsops.c
Message-ID: <20011213154249.C19995@sunbay.com>
References: <200112131308.fBDD8Zm59173@freefall.freebsd.org> <603.1008249558@axl.seasidesoftware.co.za>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <603.1008249558@axl.seasidesoftware.co.za>
User-Agent: Mutt/1.3.23i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Dec 13, 2001 at 03:19:18PM +0200, Sheldon Hearn wrote:
> 
> 
> On Thu, 13 Dec 2001 05:08:35 PST, Sheldon Hearn wrote:
> 
> >   Modified files:
> >     sys/fs/smbfs         smbfs_vfsops.c 
> >   Log:
> >   Add module dependency on libmchain.
> >   
> >   With this change, mounting an smb share (using mount_smb, which is not
> >   yet included in the tree) without any of smbfs, libiconv or libmchain
> >   compiled into the kernel or loaded works.
> 
> I included <sys/module.h>, which is already included by <sys/kernel.h>.
> 
> I did this because I'm guessing it's _not_ okay to assume that
> <sys/kernel.h> will include <sys/module.h>.
> 
> Am I right, or should I remove the explicit inclusion of <sys/module.h>?
> 
Look at the line preceding the inclusion of <sys/module.h> in
<sys/kernel.h>.  :-)


Cheers,
-- 
Ruslan Ermilov		Oracle Developer/DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message