From owner-svn-ports-head@FreeBSD.ORG Tue Sep 9 02:53:33 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C41F9375; Tue, 9 Sep 2014 02:53:33 +0000 (UTC) Received: from sender1.zohomail.com (sender1.zohomail.com [74.201.84.156]) by mx1.freebsd.org (Postfix) with ESMTP id A4A1E1C84; Tue, 9 Sep 2014 02:53:33 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version; b=UsxKDqFmqoSuufZUmAJNo7b2BeQTb5a7BIsTOJYJ5rrdrWkUyzvymrmeYw212vjVcPZLXTZtelTl Oz9Ie9FJtnTDApOs0CgpYoKgdijW9LBRpOOTJLC/A7fF6/9ZOZXD Received: from [192.168.11.5] (46.229.54.117 [46.229.54.117]) by mx.zohomail.com with SMTPS id 1410231204778635.0630584191623; Mon, 8 Sep 2014 19:53:24 -0700 (PDT) Subject: Re: svn commit: r367404 - in head/security: . webshag webshag/files From: clutton To: Baptiste Daroussin In-Reply-To: <20140907234259.GC6096@ivaldir.etoilebsd.net> References: <201409060746.s867kwJ4038485@svn.freebsd.org> <540AD4A8.4050705@FreeBSD.org> <540AD92E.5030602@marino.st> <20140907234259.GC6096@ivaldir.etoilebsd.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Sep 2014 05:53:18 +0300 Message-ID: <1410231198.15837.10.camel@eva02.mbsd> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-ZohoMail: Ss SS_10 UW UB UW UB SF_TD_EXT SGR3_1_26084_274 X-ZohoMail-Owner: <1410231198.15837.10.camel@eva02.mbsd>+zmo_0_ X-ZohoMail-Sender: 46.229.54.117 X-Zoho-Virus-Status: 2 X-ZohoMailClient: External Cc: svn-ports-head@freebsd.org, koobs@FreeBSD.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Carlo Strub X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 02:53:33 -0000 On Mon, 2014-09-08 at 01:42 +0200, Baptiste Daroussin wrote: > On Sat, Sep 06, 2014 at 11:51:42AM +0200, John Marino wrote: > > On 9/6/2014 11:32, Kubilay Kocak wrote: > > > On 6/09/2014 5:46 PM, Carlo Strub wrote: > > >> +LICENSE= GPLv3 > > > > > > LICENSE_FILE > > > > I know mat's position, but this decree was definitely controversial. > > Many people don't agree that LICENSE_FILE is needed when the provided > > license is identical to the one offered in ports Templates directory. > > And since the licensing framework is still an unsupported and mostly > > undocumented red-headed stepchild of ports, I don't think I agree with > > saying this was an error. > > > > >> +bin/webshag_cli > > >> +%%WXGTK%%bin/webshag_gui > > >> +%%ETCDIR%%.conf > > > > > > Does this need a filename? > > > > > > This is probably a wonderful side effect of make makeplist which > > aggressively creates SUB replacements, often incorrectly. > > This was probably /etc/${PORTNAME}.conf and it got transformed and > > submitter didn't check closely enough. > > > > I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT! > > > This is why the first line of make makeplist if wrong so one has to review! > > regards, > Bapt I've just fixed the port. And there is how I made mistake: %%WXGTK%% is an option which defines from (OPTIONS_DEFINE=NMAP WXGTK and OPTIONS_SUB=yes) so there's no need for /. And %%ETCDIR%% is a path. We have some ambiguously here with OPTIONS framework. Should there be the space? Between the %%WXGTK%% and the bin/webshag_gui? Observing other ports I can't see the space between...