From owner-svn-ports-head@freebsd.org Wed Jul 22 12:44:38 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52EA39A61F1; Wed, 22 Jul 2015 12:44:38 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (ptrcrt.ch [37.252.124.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0D8CF18E2; Wed, 22 Jul 2015 12:44:36 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from webmail.ptrcrt.ch (192.168.1.2 [192.168.1.2]); by mail.ptrcrt.ch (OpenSMTPD) with ESMTPSA id f8c10a2d; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 22 Jul 2015 12:44:34 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 22 Jul 2015 14:44:34 +0200 From: Pietro Cerutti To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r392666 - head/audio/libgroove Organization: The FreeBSD Project In-Reply-To: <20150722122531.GB50653@FreeBSD.org> References: <201507220652.t6M6qVFO094263@repo.freebsd.org> <20150722122313.GA50653@FreeBSD.org> <20150722122531.GB50653@FreeBSD.org> Message-ID: X-Sender: gahr@FreeBSD.org User-Agent: Roundcube Webmail/1.1.2 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 12:44:38 -0000 On 2015-07-22 14:25, Alexey Dokuchaev wrote: > On Wed, Jul 22, 2015 at 12:23:13PM +0000, Alexey Dokuchaev wrote: >> On Wed, Jul 22, 2015 at 01:49:37PM +0200, Pietro Cerutti wrote: >> > > @@ -1,29 +1,29 @@ >> > > -# Created by: gahr >> > > +# Created by: Pietro Cerutti >> > >> > I would have appreciated you notifying me of such change. >> > Is this modification really needed? >> >> It's obviously not *really* needed as it touches Makefile header, thus >> being >> non-functional. On on the other hand, we're not forbidding >> non-functional >> changes, right? :) [...] >> >> > Are you going to change all similar occurrences in the ports tree? >> >> I won't convert them in bulk, most certainly. I do expand them when I >> notice one (and was not asked to leave that/those particular one >> alone). In clear contrast with the PHB, which states "If this line is present, future maintainers must not change or remove it except at the original author's request." It does *not* say "Future maintainers can change it if not explicitly asked not to.". Look, we do have rules so we don't have to argue about taste, style, what's more sensible to you, etc. > Sorry I forgot to ask: so any problem with expansion? Yes, I do. Please revert. -- Pietro Cerutti gahr@FreeBSD.org