From owner-cvs-all  Sat Mar 31  7:20: 6 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2D47937B719; Sat, 31 Mar 2001 07:19:59 -0800 (PST)
	(envelope-from adrian@FreeBSD.org)
Received: (from adrian@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2VFJxG21895;
	Sat, 31 Mar 2001 07:19:59 -0800 (PST)
	(envelope-from adrian)
Message-Id: <200103311519.f2VFJxG21895@freefall.freebsd.org>
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Sat, 31 Mar 2001 07:19:59 -0800 (PST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sbin/fsck_ifs pass5.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

adrian      2001/03/31 07:19:59 PST

  Modified files:
    sbin/fsck_ifs        pass5.c 
  Log:
  Quoting from the email thrown around between kirk, bde and iedowse@..
  
  <QUOTE>
  Overflow of cg_niblk causes spurious "SUMMARY INFORMATION BAD" warnings
  prompts in fsck_ffs.  cg_niblk has type int16_t, but it is (ab)used
  to hold the number of inodes per group (it has nothing to do with the
  number of inode blocks in the cg as claimed in ffs/fs.h), and there
  can be lots of inodes per group.  E.g.,
  
      newfs -i 8192 -b 16384 -f 16384 -c 255 ...
  
  gives 0xA900 inodes/group.  Assignment of this to cg_niblk gives
  -0x5700.  This is mostly harmless (ufs/ffs doesn't use cg_niblk, and
  bug-for-bug compatible overflow occurs in newfs), but in
  fsck_ffs/pass5.c, negative values of cg_niblk limit cg_irotor to 0
  and the summary info appears to be bad.
  </QUOTE>
  
  Submitted by:	Bruce Evans <bde@zeta.org.au>
  Obtained from:	Kirk McKusick <mckusick@mckusick.com>
  
  Revision  Changes    Path
  1.19      +6 -2      src/sbin/fsck_ifs/pass5.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message