From owner-freebsd-geom@freebsd.org Fri Apr 21 19:45:04 2017 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1CC9D49F5A for ; Fri, 21 Apr 2017 19:45:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D1A243F1 for ; Fri, 21 Apr 2017 19:45:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3LJj4gY061275 for ; Fri, 21 Apr 2017 19:45:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 218512] Geli arbitrarily prevents setting passphrases Date: Fri, 21 Apr 2017 19:45:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: fhriley@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 19:45:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218512 --- Comment #10 from Frank --- (In reply to Alexander Motin from comment #9) It's not paranoia at all. If you don't specify -i, the iterations are not s= et to -1, they are computed and passed in. When setting passphrases on a set of disks, freenas serializes that process, but what if I wanted to parallelize= it? geli is happily computing iterations on the cpus when another task happens = to come in. One or more of the iterations end up getting computed differently = that what it is currently set to and subsequently causing one or more passphrase changes to fail. This is but one of many scenarios of how this could really happen. Of course, I thought of all this when I made my changes, and I added tests = to test those changes. But I suppose it's the state of software these days to = make the easy fix for the specific use case I care about. This will be my last comment on this as I am not a committer to freebsd, but if I were, I would label the commit as incomplete. --=20 You are receiving this mail because: You are the assignee for the bug.=