From owner-svn-src-all@FreeBSD.ORG  Thu Nov 27 18:35:54 2008
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAB5E106564A;
	Thu, 27 Nov 2008 18:35:54 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 9FB618FC1B;
	Thu, 27 Nov 2008 18:35:54 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id mARIZpRe075656
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 27 Nov 2008 10:35:51 -0800 (PST) (envelope-from sam@freebsd.org)
Message-ID: <492EE887.8080901@freebsd.org>
Date: Thu, 27 Nov 2008 10:35:51 -0800
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Ivan Voras <ivoras@gmail.com>
References: <200811270219.mAR2Ji2M073024@svn.freebsd.org>	
	<20081126213204.14db9a63@kan.dnsalias.net>	
	<20081127.000621.1413927847.imp@bsdimp.com>	
	<9bbcef730811270220h1a7f812k2ba340737132ff82@mail.gmail.com>	
	<8663m94g30.fsf@ds4.des.no>
	<9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com>
In-Reply-To: <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@freebsd.org,
	=?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2008 18:35:54 -0000

Ivan Voras wrote:
> 2008/11/27 Dag-Erling Smørgrav <des@des.no>:
>   
>> "Ivan Voras" <ivoras@gmail.com> writes:
>>     
>>> And at least the newer GEOM code also uses c99 variable declarations
>>> (not only for initializers - they were c99 from the start).
>>>       
>> I'm curious about what you mean with "c99 variable declarations".  If
>> you are referring to loop variable declarations, I can only find two
>> cases, both in g_linux_lvm.c.  Other than that and mixing declarations
>> with statements (which style(9) explicitly forbids), there is no
>> difference between c89 to c99 as far as variable declarations are
>> concerned.
>>     
>
> Yes, but not only loops - I mean things like:
>
> if () {
>   struct *something abc;
>   int y;
>   ...
> }
>
> You'll probably find my code is one the biggest users of this style
> but I've only started using it when I saw it already used.
>
>   

Repeat after me: "style is a guideline and not a contract".

    Sam