From owner-cvs-src-old@FreeBSD.ORG Sun Jun 27 14:21:21 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC28010656D8 for ; Sun, 27 Jun 2010 14:21:21 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B9C6B8FC18 for ; Sun, 27 Jun 2010 14:21:21 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5RELLcw032642 for ; Sun, 27 Jun 2010 14:21:21 GMT (envelope-from gavin@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5RELLrA032641 for cvs-src-old@freebsd.org; Sun, 27 Jun 2010 14:21:21 GMT (envelope-from gavin@repoman.freebsd.org) Message-Id: <201006271421.o5RELLrA032641@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to gavin@repoman.freebsd.org using -f From: Gavin Atkinson Date: Sun, 27 Jun 2010 14:21:08 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tftp tftp.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2010 14:21:21 -0000 gavin 2010-06-27 14:21:08 UTC FreeBSD src repository Modified files: usr.bin/tftp tftp.c Log: SVN rev 209551 on 2010-06-27 14:21:08Z by gavin Fix transfer statistics in the "send file" case - The conditional used to print the stats were using an uninitialised variable. [1] Fix trasnfer statistics in the "receive file" case - the statistics struct was being cleared both before and after the initial connect to the remote server. As a result, the printed time and calculated bandwidth covers the time to connect ad well as the time to transfer the file. This may not be ideal, but now at least matches the "send file" case. Found by: clang static analyser [1] Reviewed by: imp Revision Changes Path 1.18 +1 -4 src/usr.bin/tftp/tftp.c