From owner-cvs-all  Sat Dec 14 13: 1:11 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EFE0837B401; Sat, 14 Dec 2002 13:01:09 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1C88843EC2; Sat, 14 Dec 2002 13:01:09 -0800 (PST)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gBEL0qJe023880;
	Sat, 14 Dec 2002 22:00:52 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: John Baldwin <jhb@FreeBSD.org>
Cc: Peter Wemm <peter@wemm.org>, cvs-all@FreeBSD.org,
	cvs-committers@FreeBSD.org, "Tim J. Robbins" <tjr@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern kern_descrip.c 
From: phk@FreeBSD.org
In-Reply-To: Your message of "Fri, 13 Dec 2002 17:38:32 EST."
             <XFMail.20021213173832.jhb@FreeBSD.org> 
Date: Sat, 14 Dec 2002 22:00:52 +0100
Message-ID: <23879.1039899652@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <XFMail.20021213173832.jhb@FreeBSD.org>, John Baldwin writes:
>
>On 13-Dec-2002 Peter Wemm wrote:
>> "Tim J. Robbins" wrote:
>>> tjr         2002/12/13 01:59:40 PST
>>> 
>>>   Modified files:
>>>     sys/kern             kern_descrip.c 
>>>   Log:
>>>   Drop filedesc lock and acquire Giant around calls to malloc() and free().
>>>   These call uma_large_malloc() and uma_large_free() which require Giant.
>>>   Fixes panic when descriptor table is larger than KMEM_ZMAX bytes
>>>   noticed by kkenn.
>> 
>> What about things like geom which explicitly call malloc without Giant?
>> Or is it just a problem for large allocations?
>
>Just for large allocations which call uma_malloc_large().

Uhm, and just what is the magic size where this happens ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message