From owner-freebsd-current@FreeBSD.ORG  Thu Jun  3 07:29:44 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A168016A4CE
	for <freebsd-current@FreeBSD.org>;
	Thu,  3 Jun 2004 07:29:44 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 742C943D2D
	for <freebsd-current@FreeBSD.org>;
	Thu,  3 Jun 2004 07:29:44 -0700 (PDT)	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 692D35C873; Thu,  3 Jun 2004 07:29:44 -0700 (PDT)
Date: Thu, 3 Jun 2004 16:29:44 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Christian Weisgerber <naddy@mips.inka.de>
Message-ID: <20040603142944.GJ9228@elvis.mu.org>
References: <c9ltb3$13cb$1@kemoauc.mips.inka.de>
	<20040603012501.GA5035@thingy.tbd.co.nz>
	<20040603140245.GA79548@kemoauc.mips.inka.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040603140245.GA79548@kemoauc.mips.inka.de>
User-Agent: Mutt/1.4.2.1i
cc: freebsd-current@FreeBSD.org
Subject: Re: Network driver jumbo patch (affects multicast)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jun 2004 14:29:44 -0000

Christian Weisgerber wrote:
> Andrew Thompson:
> 
> > You have removed the following comment from if_xl.c. The two notes are
> > still relevant, should they stay?
> > 
> > - * Note: the 3c905B currently only supports a 64-bit hash table,
> > - * which means we really only need 6 bits, but the manual indicates
> > - * that future chip revisions will have a 256-bit hash table,
> > - * hence the routine is set up to calculate 8 bits of position
> > - * info in case we need it some day.
> > - * Note II, The Sequel: _CURRENT_ versions of the 3c905B have a
> > - * 256 bit hash table. This means we have to use all 8 bits regardless.
> > - * On older cards, the upper 2 bits will be ignored. Grrrr....
> 
> I think it's just rambling.

I tend to disagree, I find this comment a valuable technical information.
This is one very cool thing with Bill Paul drivers, they are very well
commented, and I don't think we should change that.  At the very least,
this change should be separate to the one that uses the new multicast
hash functions.

Cheers,
Maxime