From owner-svn-src-all@FreeBSD.ORG Fri Oct 24 22:53:06 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C70C4106566C; Fri, 24 Oct 2008 22:53:06 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 837A28FC08; Fri, 24 Oct 2008 22:53:06 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m9OMoZtp003546; Fri, 24 Oct 2008 16:50:36 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 24 Oct 2008 16:50:35 -0600 (MDT) Message-Id: <20081024.165035.41635952.imp@bsdimp.com> To: xcllnt@mac.com From: Warner Losh In-Reply-To: References: <20081023.191014.41711418.imp@bsdimp.com> <49018C68.3020706@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, marcel@FreeBSD.org, bms@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184194 - in head/sys: conf mips/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 22:53:06 -0000 From: Marcel Moolenaar Subject: Re: svn commit: r184194 - in head/sys: conf mips/conf Date: Fri, 24 Oct 2008 09:04:32 -0700 > > On Oct 24, 2008, at 1:50 AM, Bruce M. Simpson wrote: > > > Warner Losh wrote: > >>> Add mips/conf/DEFAULTS and populate it with: > >>> machine arm > >>> device mem > >>> device uart_ns8250 > >>> options GEOM_BSD > >>> options GEOM_MBR > >>> Remove the first three from all kernel configuration files > >>> (sometimes commented-out) and change geom_bsd and geom_mbr > >>> from standard to optional. > >>> > >> > >> We shouldn't be using DEFAULTS for this. > >> > > > > I agree. Marcel, can you please back this change out (at least the > > mips or SENTRY5 part of it) ? > > > > uart support isn't ready on SENTRY5; shipping these drivers in a > > default configuration just adds dead wood on a platform where kernel > > size is critical. > > I have no problem reverting, but the reasons you put forward > don't hold. uart(4) is not enabled by default so there's no > change to the SENTRY5 configuration at all in that respect. > Please provide other grounds for reversal. (1) You didn't ask us first. (2) Others have said this is a bad idea. (3) There's appears to be a conensus that we should move the other way from what you are doing. Warner