From owner-svn-src-all@freebsd.org Tue Dec 1 06:24:28 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1EACEA3E8D2; Tue, 1 Dec 2015 06:24:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E48501AEE; Tue, 1 Dec 2015 06:24:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacdm15 with SMTP id dm15so211206037pac.3; Mon, 30 Nov 2015 22:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UVJqd7VcvU1lZ8I2vH+hwGK8Z2YLLb19t1njGAbgCEE=; b=Aj8A/8Db08v9h5ITr3hzlT5svEFw1pasEsbv+Y13IXCC7NZSnCqGPxvWhjU5CUXdFH eSx5c74OwFQl28cfBf29SK0sDUkgr7jv+jZBjBeLOmhlww3raTIsCyzpAiF71zEJJGvU cCoa/4kevcGri5AdPsVjpT1lrdQn9jpyAXXCWxIKE0zRJY5qYsCkEw9LsPhroflLDI/Z k1jmum3mk8ESDNt8B2zPm/K5GxEL97U3/jxL9Y4ER6pCZjfH0IOJ9kQ1MNHBkG9eu1o2 qXH6149zdrid7gZ2XQQUEydVLOsgxkNC8M/xBCU86g6ek/zb7uMtfTNRMPkql/uJQ/dq mixQ== X-Received: by 10.98.72.18 with SMTP id v18mr76975057pfa.68.1448951067592; Mon, 30 Nov 2015 22:24:27 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id x79sm55142526pfi.47.2015.11.30.22.24.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 Nov 2015 22:24:26 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r290840 - head/etc From: NGie Cooper In-Reply-To: <565CB930.2060504@FreeBSD.org> Date: Mon, 30 Nov 2015 22:24:24 -0800 Cc: Ian Lepore , Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, gjb@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <59366F9C-0F8C-4B19-A197-32BC8B86DFA4@gmail.com> References: <201511150304.tAF34dD2062713@repo.freebsd.org> <1447597638.1254.16.camel@freebsd.org> <565CB930.2060504@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 06:24:28 -0000 > On Nov 30, 2015, at 13:01, Bryan Drewery wrote: =85 > I have concerns this may break the install image that re@ (or other > parties) produce as well since it may have a broken /sys link if not > built from /usr/src. >=20 > Looking at the freebsd-update kernel I see > "root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC" which = means > that the freebsd-upate one should be fine. Not sure about other = images. >=20 > In general I think this is wrong. For meta mode staging I am tempted = to > disable this, but that's no different than non-meta mode really for > images. I don't like the symlink at all, but having it point to = usr/src > is at least only 1 symlink that needs to be setup to fix all = assumptions > (usr/src -> /real/src), rather than now having up to 2 symlinks that > need fixing. I mulled over the change and I agree that the risks outweigh the benefit = (as annoying as it seems to folks like me), so I reverted it in r291568. = I can script /sys install as needed for my environment. Thanks, -NGie=