From nobody Thu Aug 6 01:42:22 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlg4tj6z6nZ35 for ; Thu, 06 Aug 2026 01:42:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFqlg2MhXz3Trp for ; Thu, 06 Aug 2026 01:42:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aOLgMmBH2ILd7vJTWrMjZ3/jmPmmq+F3k9SBWsZDtF8=; b=Rkl9O1UxAIdEJ6pU+gWklZZrv/Qb/9xryTemxmnOW1g4uAIE62V2RN1RSG1e23L282+skQ ik0UY91CcVmBLYcasS01uCgfk3ofsN1QYZj3PWwKSb4HTeayMLXJtVOCZ/Z+DtOFhUXP0z vU5FWjZ3rITRCnBgW67uEKAbwRfKS5/JIRKiFUR/A9zbGyGjEFLpNPlqVYt9mt2CD1kqKH jsEcKlAoGnLp7PY8seTg27vXtaF/x5QAz+DUEiyoBRjLXVNsnOFq38j2XEv6VRHt1iSfb3 iYVtcSVL7fHUMZXkC+f+EjO/s1w9SHFtBIRK2mZXmVj+BmMZPlSJ8PJKRbpITQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785980543; a=rsa-sha256; cv=none; b=DF2/plZhAf4LYo0b3iKTt6uTiNtccfaRWzbEGfY43P0vdmrl1Zruj/0u2SXPEKf3cNshcA d8qN0cwwViDl9sg2ez8np3FOwVpAtQVXf1FZf7wo9E3L7keNbOSyNHiePEAPoadhc2SRUD 6mFrMHaz9jNPs1gkBGEUWEAllz8bfcx0MAs9rqFXrEqeZjlZw5WMD+Ia3gFNlSmGHFJvyf R+vW0SCFRO8gcYxRA4vA356jZ0+YpvGwbc0cg075c2/p9mvzC063Z8M8/QeVXal52+5nml 5OZl5SWOKAOQppkYVVUcNwVuekBVHjYnZg0h0bQ225wUbR4EjBMESDb6WXm/uQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aOLgMmBH2ILd7vJTWrMjZ3/jmPmmq+F3k9SBWsZDtF8=; b=d5caV3FwEokDXRffqpqa5iqko+vRMu9eeiQyO8CQxwvHz7XziR3I1oHgTroWllmjf3494j BMepEPAXpM4Tzhxwt3yeLhqzIPPycdfy5wqUmYj3CHrAI0A3sdRyEq0cBoxTvNJ/G8xsDT TcE40qlR/EgVeGSOXBlclZ2zlVmHip2hoBSQZs0WalPUKZkl3QBSNrNtVBq77QSkXc2OeX sklCWEsxyvgupaBM/9Avkhlt6Gkn8Y7+2nbwowzNx677M7CVvKsEQI4gXrynu2GN8sBtes TMqDb4dwBcaaYlsiJAOVHJ4PS9Yrh4VWKtpX8hPcZPyGUo1exdN+oXr8tQVA7A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlf6qRRz10NC for ; Thu, 06 Aug 2026 01:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39f94 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 01:42:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Li-Wen Hsu Subject: git: ffdac5099420 - stable/14 - libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: lwhsu X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ffdac5099420c77ce658fed66e7eacd58b48b60e Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 01:42:22 +0000 Message-Id: <6a73e67e.39f94.17b0f7b@gitrepo.freebsd.org> The branch stable/14 has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=ffdac5099420c77ce658fed66e7eacd58b48b60e commit ffdac5099420c77ce658fed66e7eacd58b48b60e Author: Li-Wen Hsu AuthorDate: 2026-06-27 02:26:05 +0000 Commit: Li-Wen Hsu CommitDate: 2026-08-06 01:40:12 +0000 libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode dt_print_sym() fills the symbol string via snprintf() in non-oformat mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf() call causes the symbol is computed but never emitted. This fixes tests: - common.profile-n.t_dtrace_contrib.tst_sym_ksh - common.profile-n.t_dtrace_contrib.tst_func_ksh Reviewed by: markj Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Room 208, Computer Science Building, Dalhousie University Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57895 (cherry picked from commit 8e61d8707f8a10acc143210089fea2502a3f2922) --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c index 56418d7283b6..8938a6a2bc3e 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c @@ -2143,7 +2143,7 @@ dt_print_sym(dtrace_hdl_t *dtp, FILE *fp, const char *format, caddr_t addr) } } - if (dtp->dt_oformat != 0 && dt_printf(dtp, fp, format, c) < 0) + if (!dtp->dt_oformat && dt_printf(dtp, fp, format, c) < 0) return (-1); return (0);