From owner-freebsd-arch@freebsd.org Thu Dec 3 08:07:17 2015 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 685C2A3F77F for ; Thu, 3 Dec 2015 08:07:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A1331360; Thu, 3 Dec 2015 08:07:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacdm15 with SMTP id dm15so64142209pac.3; Thu, 03 Dec 2015 00:07:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SecHbEKAc3UE9XikYPiYzaP91dDG+QF2MvRjnimUDwQ=; b=WTP62j25nGQAD9DvsAIN3WYz+Pzw8Y7vzMNyW5mTozJueVia9ZFMIvLbELjIxuYJYV hkhMezZV9FY0zde3jmCCBrf7yeDudKEDrEHomXHr69959s3VHPb7FcfSzNB/3lH4ySLG AFujO68XO+NxUB/HyKTfmuIKu/w0rN9cFla4MKYVqJ7Naj0YvwmeXx7CQPrTSdhhbHcO 6Os4itBi6Lwe+CjhLleETx1HvwrPKppUlDw9eQsXMzDdCJLYpSWzRIuKCKevIhDgY+NW XXPq3JwfoSMgJoZJn5AYgVZ10WGOSextRsE2+pmPIwRFaRWs807zzvad+E8DOdDqglPu syGA== X-Received: by 10.98.64.136 with SMTP id f8mr11227671pfd.95.1449130036852; Thu, 03 Dec 2015 00:07:16 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id r79sm8801399pfa.61.2015.12.03.00.07.15 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Dec 2015 00:07:15 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Removing build metadata, for reproducible kernel builds From: NGie Cooper In-Reply-To: Date: Thu, 3 Dec 2015 00:07:14 -0800 Cc: Warner Losh , "freebsd-arch@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <4D787F21-4607-44F0-9CA8-CB2323DD72AA@gmail.com> References: To: Ed Maste X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 08:07:17 -0000 > On Dec 2, 2015, at 23:55, Ed Maste wrote: >=20 > On 3 December 2015 at 05:51, Warner Losh wrote: >>=20 >> I noted in the review that I don=E2=80=99t like the default being no. >>=20 >> I also don=E2=80=99t like that we=E2=80=99re growing lots of = different knobs that need >> to be set to get a repeatable build. Let=E2=80=99s have one, or = barring that, >> let=E2=80=99s have one that sets all the sub-knobs. >=20 > My hope is that we'll have a reproducible build by default, and that > *no* knobs need to be set. That's what I intend with my patch. I can > rename the knob to WITH_/WITHOUT_REPRODUCIBLE_BUILD though if that's > generally desired. If there's a consensus to default to including the > metadata I'm fine with setting it in make release. >=20 >> I think that host and path are more worthless than date and time >> in many environments. Who builds it likewise. Those are all things >> that are likely to change between builds, yet change the kernel >> image. I=E2=80=99d rather see it all gone when this option is in = effect. >=20 > I don't follow -- other than the build iteration number (which I > indeed missed), it is all gone. I personally like being able to debug when user A builds on machine X vs = user B on machine Y =E2=80=94 because it's helped me find issues with = peoples=E2=80=99 build environments in the past where I could have ended = up pulling teeth. I think the single-knob src.conf knob approach is wrong though. Why not = document how to do it with build(7) and tweak newvers.sh to do this = (which drives this to begin with)? That would generalize the solution, = accomplish this goal, and help $work accomplish this goal, because right = now we ($work) hack newvers.sh in order to change the version = information to brand the product appropriately, instead of build upon = existing infrastructure, as the existing infrastructure is not flexible = and documented and is very static. Thanks, -NGie=