From owner-freebsd-bugs@freebsd.org Sat Jan 26 06:38:12 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FC1E14B4855 for ; Sat, 26 Jan 2019 06:38:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 25AB66ABC3 for ; Sat, 26 Jan 2019 06:38:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D7DF314B4854; Sat, 26 Jan 2019 06:38:11 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4E9A14B4853 for ; Sat, 26 Jan 2019 06:38:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5D22C6ABC1 for ; Sat, 26 Jan 2019 06:38:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 81DA86BAC for ; Sat, 26 Jan 2019 06:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0Q6cA6t018992 for ; Sat, 26 Jan 2019 06:38:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0Q6cAHF018991 for bugs@FreeBSD.org; Sat, 26 Jan 2019 06:38:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 68437] [patch] conscontrol(8) DEVDIR -> _PATH_DEV fix and more Date: Sat, 26 Jan 2019 06:38:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 5.2-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gonzo@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Rejected X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2019 06:38:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D68437 Oleksandr Tymoshenko changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Rejected Status|Open |Closed CC| |gonzo@FreeBSD.org --- Comment #2 from Oleksandr Tymoshenko --- I don't think the gain from style clean up is significant enough for a comm= it.=20 The proposed change, in my opinion, would be fine for actively developed co= de but amount of effort that would be spent on re-verification of well-tested = and established functionality is not worth the benefits of moving things around= a bit.=20 Also adding check for conditions that is not part of current spec and might= (or might not) happen in the future is not a good practice. If anybody wants to pick up the patch and commit it feel free to reopen the= PR. --=20 You are receiving this mail because: You are the assignee for the bug.=