Date: Tue, 30 Sep 2014 11:31:31 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-net@freebsd.org Cc: Andrew Rybchenko <arybchenko@solarflare.com> Subject: Re: Choice of private ioctl approach Message-ID: <201409301131.31309.jhb@freebsd.org> In-Reply-To: <54295246.6010502@solarflare.com> References: <54295246.6010502@solarflare.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, September 29, 2014 8:36:22 am Andrew Rybchenko wrote: > Hello, > > we need to add private ioctl to the driver sfxge(4) to make FW update, > do internal diagnostics commands etc. > We see at least two approaches in other drivers: > 1. SIOCGPRIVATE_0/ SIOCGPRIVATE_1 on net device > 2. dedicated char device with its own ioctl's > > Is there any recommendations on which way is preferred? I would be inclined towards 2). It is more flexible if you need to add more custom ioctls in the future. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409301131.31309.jhb>