From owner-svn-ports-head@FreeBSD.ORG  Wed Mar 12 11:48:47 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 05FC5D5E;
 Wed, 12 Mar 2014 11:48:47 +0000 (UTC)
Received: from mailrelay003.isp.belgacom.be (mailrelay003.isp.belgacom.be
 [195.238.6.53]) by mx1.freebsd.org (Postfix) with ESMTP id 25C6FFAC;
 Wed, 12 Mar 2014 11:48:45 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AmEGADVJIFNR8nVV/2dsb2JhbABagwY7S8FdgRoXdIIlAQEBBDocIxALDgYECSUPKh4GE4d9AQjRVBeOXAeEOASYRIEzkHuDLjw
Received: from 85.117-242-81.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([81.242.117.85])
 by relay.skynet.be with ESMTP; 12 Mar 2014 12:48:39 +0100
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s2CBmcEm002772;
 Wed, 12 Mar 2014 12:48:38 +0100 (CET)
 (envelope-from tijl@FreeBSD.org)
Date: Wed, 12 Mar 2014 12:48:38 +0100
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r347897 - head/devel/git
Message-ID: <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org>
In-Reply-To: <AE1AAB14BF419A28B0CE399B@atuin.in.mat.cc>
References: <201403111758.s2BHwmaJ008196@svn.freebsd.org>
 <AE1AAB14BF419A28B0CE399B@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Mar 2014 11:48:47 -0000

On Wed, 12 Mar 2014 11:09:02 +0100 Mathieu Arnold wrote:
>+--On 11 mars 2014 17:58:48 +0000 Tijl Coosemans <tijl@FreeBSD.org> wrote:
>| Author: tijl
>| Date: Tue Mar 11 17:58:47 2014
>| New Revision: 347897
>| URL: http://svnweb.freebsd.org/changeset/ports/347897
>| QAT: https://qat.redports.org/buildarchive/r347897/
>| 
>| Log:
>|   Prevent detection of libcharset.h from converters/libiconv.
>|   
>|   This forces git to use nl_langinfo() from libc instead of
>| locale_charset()   from libiconv.  (The latter is practically an alias
>| for the first.)   
> 
> This need a PORTREVISION bump, doesn't it ?

I decided not to bump it, but it is an edge case.  This commit fixes
a build error on FreeBSD 10 with libiconv installed.  When libiconv
is not installed it does not change anything.  On FreeBSD 8 and 9 it
does change git to use nl_langinfo() instead of locale_charset() but
these functions are the same and git still links with libiconv for
other functions.  So the dependencies stay the same, pkg-plist stays
the same and the overall functionality stays the same.