From owner-freebsd-current@FreeBSD.ORG  Wed Sep  3 04:43:11 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF1A216A4BF; Wed,  3 Sep 2003 04:43:11 -0700 (PDT)
Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 330AF43FD7; Wed,  3 Sep 2003 04:43:09 -0700 (PDT)
	(envelope-from danfe@regency.nsu.ru)
Received: from mail by mx.nsu.ru with drweb-scanned (Exim 3.35 #1 (Debian))
	id 19uW4f-000309-00; Wed, 03 Sep 2003 18:45:21 +0700
Received: from regency.nsu.ru ([193.124.210.26])
	by mx.nsu.ru with esmtp (Exim 3.35 #1 (Debian))
	id 19uW4e-0002yQ-00; Wed, 03 Sep 2003 18:45:20 +0700
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.9/8.12.9) with ESMTP id h83BiUvt021911;
	Wed, 3 Sep 2003 18:44:30 +0700 (NOVST)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.9/8.12.9/Submit) id h83BiUOh021851;
	Wed, 3 Sep 2003 18:44:30 +0700 (NOVST)
Date: Wed, 3 Sep 2003 18:44:30 +0700
From: Alexey Dokuchaev <danfe@nsu.ru>
To: Matt <matt@xtaz.co.uk>
Message-ID: <20030903114430.GB20427@regency.nsu.ru>
References: <200309031302.01977@harrymail>
	<20030903110830.GR41860@freebsd.org.ru> <3F55CD2C.7070407@xtaz.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3F55CD2C.7070407@xtaz.co.uk>
User-Agent: Mutt/1.4.1i
X-Envelope-To: matt@xtaz.co.uk,
 osa@FreeBSD.org,
 h@schmalzbauer.de,
 ports@FreeBSD.org,
 current@FreeBSD.org
cc: ports@FreeBSD.org
cc: current@FreeBSD.org
cc: "Sergey A. Osokin" <osa@FreeBSD.org>
cc: Harald Schmalzbauer <h@schmalzbauer.de>
Subject: Re: [patch] FreeBSD Port: nvidia-driver-1.0.4365
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2003 11:43:12 -0000

On Wed, Sep 03, 2003 at 12:14:52PM +0100, Matt wrote:
> Sergey A. Osokin wrote:
> 
> >On Wed, Sep 03, 2003 at 01:01:55PM +0200, Harald Schmalzbauer wrote:
> >
> >>with today's -current the nvidia port failed to compile.
> >>With a bit luck I found that there seems to be a misstype in the 
> >>src/nvidia_sysctl.c. I'm no programmer so I don't know if this has 
> >>changed recently or if it has always been an error but the old gcc didn't 
> >>complain (I think the former)
> >>
> >>To make it short: I created patch.aa in files and it works fine with 
> >>today's -current.
> >>
> >>I don't have any -stable so if it is only an 5.x issue there someone 
> >>shuld correct the port to make the patch OS-dependent.
> >>
> >>Please commit the patch.
> >
> >
> >Hmm, where is the patch?
> >danfe: please review the patch :-)
> >
> 
> A constant in one of the kernel header file seems to have been renamed. 
> Change PCIR_HEADERTYPE to PCIR_HDRTYPE in nvidia_sysctl.c and all will 
> be well.
> 
> There is a pr for this which is ports/56157.

I'm aware of this.  However, people seem to be having other problems
with nvidia-driver on -current; they have sent patches for those as
well.  I'll review all of patches and deal with issues during very next
day or two.

./danfe