From nobody Wed Jun 24 17:01:45 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glpBy2vVzz6jVjB for ; Wed, 24 Jun 2026 17:02:18 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glpBx48yZz3SrS for ; Wed, 24 Jun 2026 17:02:17 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-697e93b0d9bso2101445a12.3 for ; Wed, 24 Jun 2026 10:02:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782320536; cv=none; d=google.com; s=arc-20240605; b=eWbHx8NNd0FgapdKPvVugkD23weDWqD6mavwg/iECJNTfpLLTuqL5QFrhX/3zjktw6 j4HaemAWe6dXmzr3iqfpQRI3iJPEo+j+4kn/SaqMGM3mupn+WnwUvHQvjNv25y9JMQQm e69MW7add3UzomZbm1rjw9QmmwJXkkRlY3zs4GT2OOrgqL64Z1fMfCrRUT39w3aClhSh 0V+EbXg5qPvZaHcaL4JzsYKM3y5uceRb7OA2DUBGaHJ9UvDjeXphYroLFOCEv/MOjerI v7hUCDnu0xknTSOXX9VBNLC6c8LSOUIat9aW/VuFlXsvMlD3ycJi8ar+JIGXh2kJUzo0 FuTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=te4acumv/2JBGZ4yo3SrgmF8G7CBCx/ga5cx7UHlbIk=; fh=SFZHKUxp0oR7T5Cfw8+4pieGR7HNINgHjvL/+gXks88=; b=XVAKp2qKc1X5s2NhIoW+sMn5ZAJJwfVDmSLUW1hEEylw+k8zB0ZCZELDQGITjTXcRt V7Z5CN9u1DGWqWUz4sihUmeoEhMvPIzZXOMXCMhTqQ6W4hU91cDnE6QJwicdnwzGF61c RakB95PZJ5RIBoo5AOpf6luzqtulCBGsOy0325JzXr7sbnQoaCT3i4dmvkdjg+x3Jt54 U+mWwx7OFjXzti8eXTGZul3G1OO6+3nTTb+T3zev3vadsQTIuTZbjoZlbzoSZMSZ1RSS K/r99ChtFO16qM9pErctwaiKc+xS+Re7m/2dmK8NyifJhJaZOfeDNDF6X6mU0U+JyroP 684A==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782320536; x=1782925336; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=te4acumv/2JBGZ4yo3SrgmF8G7CBCx/ga5cx7UHlbIk=; b=UHhlkGJ3oQkRqMvB8HdJh+8fz7+ZFYcLC+M36nqyTOptWhOm1Jfqix5w+o0iRvaIYu K1IUxfAOYJ47TTmAcnh29snh7boKHZQgGF3pZn8w/lyb2Td+Cn/adK6c6z10JVLmVJfy XqspXTBeeiTBqrCnfg5SsUsYUQlZxm5uyZYsbdMT2J0Eqp7SvhqE23aUU3R8MS+4UtD3 ANFg1sWYRTQlkNSG48Cpr0Z71IGYihmQUcMbMKtgKVqkFo8Cau6mCJhKtqSic3HgCDrz FbdBEVn25eUEi1XyiRJe2axw+59wQhMurzxmUOTxdL4PZPjnLZ4tJ/rjf0RKYWXA7odG RuKA== X-Forwarded-Encrypted: i=1; AHgh+RqDtflJSdtksSxNePy6dcoaMBx3goIrn/j4pf4nWGMfprqjYq2DF77DWhP+eAkVLfw1OFH8yqsP1CYA9pgVEaf9fyrj/Q==@freebsd.org X-Gm-Message-State: AOJu0Yw4z+DNSYlnr5JURq22JXortQ7luHjFH8IB51B1RlWuzne0Bq9m HbBJVOux+4nSaez6OgO1Ie5RnqDXkxg+YVXGL6SOZQc9pkvKx2N1usqkACqyigqbqTn9KCCwnhb fB9lOU6ALPW/jcNf8tAxcXR9JcDbJo30= X-Gm-Gg: AfdE7clQO3GqUPjcvIURQrxFhq94HGn8OkOLvGG7xZSiQrpPBSGc12KiznpEmfzHcal 9q7h9uhcS5Uv5VHsagnG4q1f/gaCY6gGY3RVNxlSdeSdQfZj3WIvTc7+PEeRcHNcqsvez3xuD0u Cv4ZPuvJdVyC9sZqqQ24GTQ4GhzPa545Fjy9kzmYDqOvSBe8+o4OUCVAVNT6G5ZDhYgVsBXDYvC HpgromgkZESwoSJHiIfDhqBlvUEDcIjatud31JZEwTO/xfxIdsHALas4+D+Tn3AMcov810PeoQF K6ha7UZgj5N7QvKUtlD/niKsuuwKKPUD3HnzDCyt7OGuWT8jODzPm15NuKUDFQvYkTFQ X-Received: by 2002:a05:6402:2349:b0:697:6226:f39c with SMTP id 4fb4d7f45d1cf-697f386f60cmr2653709a12.1.1782320518259; Wed, 24 Jun 2026 10:01:58 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> <9998a345-f864-466b-ac38-8603fc5ff359@FreeBSD.org> <4827de8d-ffbf-415a-aeca-4ec383dab315@FreeBSD.org> In-Reply-To: <4827de8d-ffbf-415a-aeca-4ec383dab315@FreeBSD.org> From: Alan Somers Date: Wed, 24 Jun 2026 11:01:45 -0600 X-Gm-Features: AVVi8CfcBIeqWDYHqoVUMFzHeK1se2QEfB9FdiIdVIbACJamdaLZVsbBbuAHWx4 Message-ID: Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally To: Bryan Drewery Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4glpBx48yZz3SrS X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Wed, Jun 24, 2026 at 10:49=E2=80=AFAM Bryan Drewery wrote: > > On 6/24/26 9:45 AM, Bryan Drewery wrote: > > On 6/24/26 9:33 AM, Alan Somers wrote: > >> On Wed, Jun 24, 2026 at 10:04=E2=80=AFAM Bryan Drewery > >> wrote: > >>> On 6/23/26 7:54 AM, Alan Somers wrote: > >>>> The branch main has been updated by asomers: > >>>> > >>>> URL: > >>>> https://cgit.FreeBSD.org/src/commit/?id=3De03ed9daeb49fffa1d16b8d002= 40c65e92650d01 > >>>> > >>>> commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 > >>>> Author: Jitendra Bhati > >>>> AuthorDate: 2026-06-12 17:07:55 +0000 > >>>> Commit: Alan Somers > >>>> CommitDate: 2026-06-23 14:53:56 +0000 > >>>> > >>>> fts: refactor to use fd-relative operations internally > >>>> > >>>> Replace all _open() calls with _openat() in __fts_open(), > >>>> fts_read(), > >>>> and fts_children(). > >>>> > >>>> Add fts_dirfd to FTSENT. Callers can use > >>>> openat(ent->fts_dirfd, ent->fts_name, ...) to access files > >>>> safely without relying on fts_accpath, which enables: > >>>> > >>>> 1. Capsicum capability mode where path-based operations fail > >>>> 2. Security-sensitive programs that avoid TOCTOU races > >>>> > >>>> Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in > >>>> fts_ufslinks() when fts_dirfd is valid, falling back to > >>>> statfs() for > >>>> root-level entries where fts_dirfd is -1 > >>>> > >>>> This is a preparatory change for fts_openat() which will allow > >>>> callers to provide a pre-opened directory fd, enabling fts(3) > >>>> traversal inside Capsicum capability mode. > >>>> > >>>> Sponsored by: Google LLC (GSoC 2026) > >>>> Reviewed by: asomers, jillest > >>>> MFC after: 2 weeks > >>>> Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 > >>> Someone on IRC reported they bisected a Poudriere breakage to this > >>> commit. > >> Really? I'd be interested to see that log. Also, Jitendra is already > >> working on the fix. > >> > > I asked for more details but haven't heard back yet. It is probably > > because Poudriere ships static binaries so is hitting the ABI break. > > > > > Sorry for the spam. I misremembered, it's not static but they are > pre-compiled dynamic binaries expecting libc to match the headers built > with. Ok, I've reverted it for now. Sorry for the breakage.