Date: Thu, 20 Dec 2012 06:00:00 GMT From: "Martin Kammerhofer" <mkamm@gmx.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/174583: devel/libreadline-java: patch for UTF8 support Message-ID: <201212200600.qBK600xV036733@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/174583; it has been noted by GNATS. From: "Martin Kammerhofer" <mkamm@gmx.net> To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/174583: devel/libreadline-java: patch for UTF8 support Date: Thu, 20 Dec 2012 06:54:57 +0100 As I haven't used Java on FreeBSD for quite some time I cannot test the patch at this time. The rationale seems clear and the patch itself useful. However for the benefit of potential long time users of the port it would be wise to make the backwards incompatibility explicit. I therefore encourage the submitter to enhance the patch with an appropriate JAVA_VERSION specification (cf. http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html ) in the Makefile! (BTW the port could be upgraded to latest upstream version too.) Best regards, Martin -------- Original-Nachricht -------- > Datum: Thu, 20 Dec 2012 00:50:07 UT > Von: Edwin Groothuis <edwin@FreeBSD.org> > An: mkamm@gmx.net > CC: bug-followup@FreeBSD.org > Betreff: Re: ports/174583: devel/libreadline-java: patch for UTF8 support > Maintainer of devel/libreadline-java, > > Please note that PR ports/174583 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174583 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212200600.qBK600xV036733>